From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbdBOOzx (ORCPT ); Wed, 15 Feb 2017 09:55:53 -0500 Received: from mail.kernel.org ([198.145.29.136]:36038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdBOOzw (ORCPT ); Wed, 15 Feb 2017 09:55:52 -0500 Date: Wed, 15 Feb 2017 09:55:47 -0500 From: Steven Rostedt To: Juri Lelli Cc: Byungchul Park , peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com, Luca Abeni Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task() Message-ID: <20170215095547.4815596f@gandalf.local.home> In-Reply-To: <20170215144503.GG1368@e106622-lin> References: <1487135511-15817-1-git-send-email-byungchul.park@lge.com> <20170215104749.GB1368@e106622-lin> <20170215092507.106f7964@gandalf.local.home> <20170215144503.GG1368@e106622-lin> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2017 14:45:03 +0000 Juri Lelli wrote: > > > > task = pick_next_pushable_dl_task(rq); > > > > Which has: > > > > BUG_ON(rq->cpu != task_cpu(task)) > > > > when it returns a task other than NULL. Which means that task_cpu(task) > > must be rq->cpu. Then if task == next_task, then task_cpu(next_task) > > must be rq->cpu as well. > > Right. Perhaps my comment should also be added in the change log. -- Steve