From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751658AbdBOPbw (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Feb 2017 10:31:52 -0500
Received: from mail.kernel.org ([198.145.29.136]:41154 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750820AbdBOPbt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Feb 2017 10:31:49 -0500
Date: Wed, 15 Feb 2017 10:31:44 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Namhyung Kim <namhyung@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2 1/2] tracing/probes: Fix a warning message to show
 correct maximum length
Message-ID: <20170215103144.40561baf@gandalf.local.home>
In-Reply-To: <20170216001030.bd1ee215ea9d31289e2441ed@kernel.org>
References: <20170210075302.GB24405@gmail.com>
        <148673290462.2579.7966778294009665632.stgit@devbox>
        <20170210110434.36d50ed2@gandalf.local.home>
        <20170216001030.bd1ee215ea9d31289e2441ed@kernel.org>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 16 Feb 2017 00:10:30 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Fri, 10 Feb 2017 11:04:34 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Fri, 10 Feb 2017 22:21:55 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >   
> > > Since tracing/*probe_events will accept a probe definition
> > > up to 4096 - 2 ('\n' and '\0') bytes, it must show 4094 instead
> > > of 4096 in warning message.  
> > 
> > Actually, during the testing I found that we don't need the '\n'.
> > 
> > 	echo -n 'p:irq do_IRQ a=@jiffies_64' > kprobe_events
> > 
> > works just fine. My tests work with 4095 characters. Before and after
> > my patch.  
> 
> Yeah, I see. I concider the case that if the writer writes 
> 4095 chars command + '\n' + next command, it will fail, that
> is what I pointed out below note.
> 
> > > 
> > > Note that there is one possible case of exceed 4094. If user
> > > prepare 4096 bytes null-terminated string and syscall write
> > > it with the count == 4095, then it can be accepted. However,
> > > if user puts a '\n' after that, it must rejected.
> > > So IMHO, the warning message should indicate shorter one,
> > > since it is safer.  
> 
> Thank you,
> 

OK, I'll just add the patch as is.

Thanks,

-- Steve