From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbdBOKo3 (ORCPT ); Wed, 15 Feb 2017 05:44:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbdBOKo2 (ORCPT ); Wed, 15 Feb 2017 05:44:28 -0500 Date: Wed, 15 Feb 2017 11:44:24 +0100 From: Jiri Olsa To: Borislav Petkov Cc: Suravee Suthikulpanit , Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, peterz@infradead.org, joro@8bytes.org, mingo@redhat.com Subject: Re: [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support Message-ID: <20170215104424.GA8207@krava> References: <1486456836-17428-1-git-send-email-Suravee.Suthikulpanit@amd.com> <20170215101323.ecggpvbkbcqaq5xs@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215101323.ecggpvbkbcqaq5xs@pd.tnic> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 15 Feb 2017 10:44:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 11:13:23AM +0100, Borislav Petkov wrote: > On Tue, Feb 07, 2017 at 02:40:28AM -0600, Suravee Suthikulpanit wrote: > > From: Suravee Suthikulpanit > > > > This patch series modifies the existing IOMMU and Perf drivers to support > > systems with multiple IOMMUs by allocating an amd_iommu PMU per IOMMU instance. > > This allows users to specify performance events and filters separately for each > > IOMMU. > > > > This has been tested on the new family17h-based server w/ multiple IOMMUs. > > Ok, so far so good. > > There's just one thing: > > $ perf stat -e amd_iommu_X/Y > > says and only doing the system wide tracing with -a does > it count events. does it say unsupported when you omit -a? it should display error and options like: [jolsa@krava perf]$ ./perf stat -e 'cpu/cpu-cycles/' Usage: perf stat [] [] -a, --all-cpus system-wide collection from all CPUs -A, --no-aggr disable CPU count aggregation -B, --big-num print large numbers with thousands' separators -C, --cpu list of cpus to monitor in system-wide ... > > So, lemme ask perf tool people, can we guys make the -a thing default > when detect that we're running only uncore events which all should need > -a anyway? it's possible, can't think of anything being hurt by this now.. jirka