From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdBOK4Y (ORCPT ); Wed, 15 Feb 2017 05:56:24 -0500 Received: from mail-eopbgr50043.outbound.protection.outlook.com ([40.107.5.43]:51790 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751873AbdBOK4V (ORCPT ); Wed, 15 Feb 2017 05:56:21 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mark.Rutland@arm.com; Date: Wed, 15 Feb 2017 10:56:12 +0000 From: Mark Rutland To: Arnd Bergmann CC: Catalin Marinas , Will Deacon , Ard Biesheuvel , Laura Abbott , Kefeng Wang , , , Subject: Re: [PATCH] arm64: fix warning about swapper_pg_dir overflow Message-ID: <20170215105612.GB31733@leverpostej> References: <20170214212718.2792194-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170214212718.2792194-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM4PR0202CA0024.eurprd02.prod.outlook.com (10.171.80.34) To HE1PR0802MB2394.eurprd08.prod.outlook.com (10.175.33.144) X-MS-Office365-Filtering-Correlation-Id: 7318f589-203a-487d-25ab-08d4559144fb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:HE1PR0802MB2394; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2394;3:0vo6/Du3kHBf6h7DQTiL7B0WvjLjVU5ZwjgaqCk/XnLZRHBb2BeMCr/x3AEIM9ndinqMRIP+V9eagM7j+3rOslmrdZcdm1ramV7hgF1hOHnODXjJ0UZGu09bejg+FLm1byg8cq3xl6KRZUYoOApaDH2VxBPjZ8vuJDCKVFOExwhj8t5z1Zz7n5IcrPt6Tpi5cVq18HjtR7QY7H/PNPRD5b5Lip+srBA384OuxkeNPIu3FTAR0tp4Ns6W4r6F7bow9VnJm5BbRvweasgtoZp9v5vyQLIGpNXD9pXffhnDaSw=;25:esMyR0fga+6WiTfpL2EwVJoJrbjTM4Zqa0sTH9gy7X3W+Cuck9Qat/DMp6F40xk/mvgyYJHkjFLxr3YujV01kHkqyKO8WdltuvkwfS6SMXEGnHPCdYDkdq3WuR2EidKXg4+h5c3ZsEXxDbTn6J3hmKxzwxGVpBHNQIvhzyQXg5TWY3ZU00+waKa+xBKlCQCsvsCxFAuG+OZurQAg3Y29k4zzGwZHtQ2QR8BlVZJsdXW5StoWJNDe/jxu+Anw6nA6MTw0q9fPq3W92auisCDIx1aEsjBL8VDQ1cZC2/iHdSr3SjcyC0npKQKUxmvlKzYorLIIDC+kIYYP8So8VK6Il3P40biqFfyDcj2oDVjhjEmfcU85SIYaAY1G1d0iGER0sh6er6R7x8jwkLxxmjKSjIZo7p9+3eJZ3oS2B/kZZnykbXj7PvJWoZtyBoWrYGeUqfM5HfbyZQa2izGhUDqOMw== X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2394;31:UMgCzGxXXCoMcSNJ7im3WfyLEv7ZLNJvJ1hDKcHizBngyF9o8CdB6+Bvw6dU8JowN/rc4grXiK8RAqXNrhIxNH5qf1ybt2eqfNPSAnwTRgrKxUKbYIk3fNz1sne0AWIBt1lY9B4fkyv6FXfzfc/vhHrFxlMflSTIdtMf5Kl+ZEo1ngxLcOMGBRjlIlAlGpGQP0isJPzNMLLa96oyY9zRlYgwoQFQZ0apjeIzaCkx6pu8zXKzGvhp0YXoby874AJl;20:UWD5Lp/EzR7nTyAgyqyg+PC/bb/8/Edi1sKFRUyn+m2APySnPtJghtJcK83GZ4YGEq9fkhfz6ECogobIwZTQ7WqA/NA4SCskT5k66MCvyCivegKaA49vsDUJsxogF4ftXVLKsyP74nMF5pztaVLzbkSfqGukY1jihnXiFAlNSxw= NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558025)(6072148);SRVR:HE1PR0802MB2394;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0802MB2394; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2394;4:SqYe2Ipxq8pT3901vGUkOpV6k/2/kGTTvqjxNgd8tc71sMQgqzqp/H9o625YxqHRHTkf4MRZLdL/4oYHbjjXhsEX2kr7IVODactLLLImbuDtA+qnPqixem+TO/YDj4SScFJGXm89Lo4ZUpZ5lCkufzHuutm99ss8FTGYPc89obUURMRNFfHfqrgcUSj1jbomAD/B6ZQht35h+1kTogi6HyvtT0rlqXpN5sYL0xmViIAunzgAk/8ch5qGH2pmMzXV5la03YROW4dIzz8JmppO5QwRujwliIvWAzrSsuzKPQ3VS+UTNTSZrPgxr+x+VuNYVLmBHujyBoBn4yL6st1q5DagAVds/VDlVgvoJjExjMsrWe13PJ6+18VCU+T/zlrFyZ9xPx2yuecT5SQ4djvgGLOnasB9oWmvcvnjj60UIbZi9zvMojoSTjH4bc/CRAtqpXr6751ekdfW4HBw2f85c/Y0jSsnWp5NHP2qPNEGt8fASW0wbyki0xVuFuwI9z1tYJaM2Axv0MCvKEtxlIxgNjDMbBjr1qMSTJQM/C4HOq3he2DvqR8oCXOPpWzFZvCHdQr5ZBarCV4cQjbRMkkJgjsjvqe93wHPX70VCQHLzZXaARsrKll8xcIPTOupgfKF2A1oxPkBSyVzS+VW2hs1lw/YYLPYx04JrSGzMRyEiBI= X-Forefront-PRVS: 021975AE46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39450400003)(39410400002)(39840400002)(39860400002)(189002)(199003)(24454002)(47776003)(189998001)(54356999)(2950100002)(76176999)(66066001)(5660300001)(6116002)(50466002)(101416001)(23726003)(50986999)(2906002)(1076002)(305945005)(3846002)(46406003)(4326007)(7736002)(92566002)(97736004)(81156014)(6496005)(81166006)(8676002)(6916009)(53936002)(229853002)(9686003)(33716001)(68736007)(33656002)(97756001)(25786008)(105586002)(106356001)(38730400002)(55016002)(54906002)(42186005)(83506001)(86362001)(6246003)(4001350100001)(110136004)(6666003)(389900002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2394;H:leverpostej;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0802MB2394;23:AvTNbci7K8EiOLfUoYgcR2nFuy6Wv5BTkasoO9Y?= =?us-ascii?Q?w2WcZaNgiJLV8CAArwp7OtjlOx8g8GwDJGNSb3tz0la5L0drIXDpSMzo3CcG?= =?us-ascii?Q?z7OycxWSaI/lWDH2y/eNgQOoe37PiAlPTdBkX4lXMg9MKuytmLS9C0GfTbtI?= =?us-ascii?Q?QfnrB3U77OkNv2lZ2lzTySFwwMKH0v+kq2/KPzGPMBKu9NXsGa62le3yP7pY?= =?us-ascii?Q?jei9Q5o4TubVdKkPJYPqyULF/7t8LL1xSpGl+uBr8NSNLQaRJDKM6/cWG7fe?= =?us-ascii?Q?AbWwy52zI7DzxIHwUGB+XiVK28eXWqYl/cJvWRRPzSr7Z5yBBMNynKJBYzey?= =?us-ascii?Q?JgdvRxwUFvFpXvddueYNl8YyS8uycO0CJY2UhcN43YJEdkomvmQarmyfJlWV?= =?us-ascii?Q?hnZ5K0kpT8WHGrouJOxEeekyMy3mHp4beHs9xibWIHp+oIZXkIcSZcYU0NlX?= =?us-ascii?Q?+biiIVhKj4K3ZkpIssz/xfqgt2gaK4ebVoMr6r9F7WCiAPpJbvqI4VZ5xfC9?= =?us-ascii?Q?XKN84sgrLny2HY/mV/kJUQ7UDYroEHH6SXaV6xfVWgM2BEuJTT6ug0YGoEHS?= =?us-ascii?Q?lbBtGgZ2NYAR3xfAHOokGmUxWUchCPukgYXdLKeYqiOxWokzKB8NAijv4nVo?= =?us-ascii?Q?qqfROFigyl1SnI+p+SCw4+w40c0lArUd8mcRC5Vq7jB0io93dvTzyaAY0qir?= =?us-ascii?Q?WjfJVSdnn52Lntbsu//pUxjg+U/cy4ki6VwrcIpF3iidkQTkfQc7x4RM9/zU?= =?us-ascii?Q?qzv71mV5nz6dSkJc3LHGvIWadokIDjTnRP5ZWe1MJTyiWENNP2Blum7LKU20?= =?us-ascii?Q?MTPAMsxt4Br6uXvsbb9B1/JUwD0J3SWXrayDWObPYjBvMhWGI+iRWcOmS/hn?= =?us-ascii?Q?7Nl75cyxnhQhNRKsTvByNAnWt6QMyOrsJPEC5OMIx+Tsssak7UJCnFxowXqR?= =?us-ascii?Q?1OYlNqphJiQUcY31Rz6/RMpJf2qlzrRIkD5cHq3ZWKOLkHWfquY7mKXi0v48?= =?us-ascii?Q?LZDt7sj8KaZbAHyk/Z7P0rLq6+IlqUj7lE251mrxgcFntnY/OPh3LBUtj1Pq?= =?us-ascii?Q?zlHUofIlZsoxwuDg3ylFEfkRXAreE0mVaTwaFmp6gQELbrvVfBBK/MnlvfRm?= =?us-ascii?Q?ewNqBF/6bnltCS66TEVUSu7xSunAFaXBOBaQoF+qg93jpXZx+z9KxTslmEXp?= =?us-ascii?Q?CzmywOevemJJSHMoIcmI38QSvPwsgNQGLW6zkcwvHFnTs5xllcdDakaIBdvy?= =?us-ascii?Q?lGWq9aF+Z0QBKGp8tJ+FlrmL4rTxWeneZTFdMluJ69ELQO2X4oRurdfWL330?= =?us-ascii?Q?Iv2l5JyVlxjrkbKKRmmgmM82x59l5IfVFXCpH3tU8jXueVdKThfFzykKfH9A?= =?us-ascii?Q?Tp79bxKvih2u9uiww0Js/9tMph8cPL2CWDuhb6Sb+8zX/SFz2TrJI8/MNxLI?= =?us-ascii?Q?J72IZaj3fhA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2394;6:nDCuq1/evoYuAKwteRief7m8TZgVL3aWvDUCbMEc0Drjdrdhk7wpGY9w3ROHLp0w8hd5YWhHIa9HyHn3wvIlwwzrqSvRdOS7mriTRPi7D1EO3CjSUZvNZSGAEI6lpfETXeJ6hR83jDifui9zehzNNLE3MOpzf9UGOLJxBhTIP0eNZylgjyRI+9yAmZeCtK2hWDaYsxwAqY5I9FxK7vrq36jx4TwZjH0cbOJ97IJrd4ZVcts200AbvGPAeEyIm9PZTBAmd1MTdraJ8HfaEYR3g5W2DzLUrnSJI695+nhlKa0M5w1ekYIHRR1yaHWcKzGqUQ7h5Cn4UkHk/brml+k5bp54lyMG2qaffgy/1Rw0QjGIz8IPE5cR5gqrn2PYvfwFeGkxc6UblFS/IB+o30t8zM0SXxDK3n70+OlLDAn66MQ=;5:DkofeJWupv7uvsuoectdvyWAP7hR2Aw57pbJPP5a2gAJ5wN3rNiM7Y5d7RZ7Q5d4qwZ+Jv1IWZjoaqR/vmjXHDOMa6+J26VIyntyAlM0wR+YVAWNpH3J0Sk5aEEOumO+1erXUykPRL6Vbj38bMUC4A==;24:27Wvfjt0LNGWShJ8aShgdFt++BjrrdA8nUz7Z+TCa9r/Zva41PfLid4Qw+6+2BufptDXojXYy7YUgGkk9WoLUgKV2NS4dTdSqDonAjBHBUE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2394;7:Hub5SrcTIgo16BeIpOOyNx+iT/0AIMC43OKnrwQruYCaVN3GHfzFYOQQAl1sG+81Z55OFReAd3wlSP4TfUJpD+kdjqiP/sIEjRX/EQq0WfGbYHULL/EtSqymzHl0l/9Yfl0G3AcZfzXnK2OjRMWXwWEZIgfXlScwQLFNmuVdCPO4nhp1U9qaFZQpXl7VWgSusf2cFF6MinXHviTftXSHv+wwBxPkIp6+tPK7PYsOP313/qUC1Qgt/hmYFQcPptDb9wi3gaZIYiR8C0KvRClBvk1y7uXeSk9SoZNFc3u8q0b7xMvzrmbneDeFvjlShY8wIRB3fwuMLtyBsWpObl2yXRH+c+3wCGcKmNvR5ED92EvmGA/VEUDloTj1u5//bQEGBJGtssKvrIsEn7NgMoQ3rK03ypQwzCgBzP3fp/6T1X0f8DxHxvT+zheJh0RJ7cPsDNxYJBvES85CuyuLE1+rlxvUofTKQJDkOaKm1pz9yawUS/B2q486PqKUXOwvVCI+8LwID94whzkRRo/kY3rdpw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 10:56:17.6466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2394 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 10:27:01PM +0100, Arnd Bergmann wrote: > With 4 levels of 16KB pages, we get this warning about the fact that we are > copying a whole page into an array that is declared as having only two pointers > for the top level of the page table: > > arch/arm64/mm/mmu.c: In function 'paging_init': > arch/arm64/mm/mmu.c:528:2: error: 'memcpy' writing 16384 bytes into a region of size 16 overflows the destination [-Werror=stringop-overflow=] > > This is harmless since we actually reserve a whole page in the definition of the > array that comes from, and just the extern declaration is short. The pgdir > is initialized to zero either way, so copying the actual entries here seems > like the best solution. > > Signed-off-by: Arnd Bergmann Acked-by: Mark Rutland Thanks, Mark. > --- > arch/arm64/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 2131521ddc24..b805c017f789 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -525,7 +525,7 @@ void __init paging_init(void) > * To do this we need to go via a temporary pgd. > */ > cpu_replace_ttbr1(__va(pgd_phys)); > - memcpy(swapper_pg_dir, pgd, PAGE_SIZE); > + memcpy(swapper_pg_dir, pgd, PGD_SIZE); > cpu_replace_ttbr1(lm_alias(swapper_pg_dir)); > > pgd_clear_fixmap(); > -- > 2.9.0 >