From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbdBOLx7 (ORCPT ); Wed, 15 Feb 2017 06:53:59 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36115 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbdBOLx5 (ORCPT ); Wed, 15 Feb 2017 06:53:57 -0500 From: Maksymilian Piechota X-Google-Original-From: Maksymilian Piechota Date: Wed, 15 Feb 2017 06:53:43 -0500 To: Greg Kroah-Hartman Cc: Maksymilian Piechota , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line Message-ID: <20170215115342.GA70990@maks-debian.localdomain> References: <8b7698a301c1e755ab8a0f1efe8414e8f792948e.1486993631.git.maksymilianpiechota@gmail.com> <20170214171631.GA1518@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214171631.GA1518@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote: > > move logical continuations at the end of line > > > > Signed-off-by: Maksymilian Piechota > > --- > > drivers/staging/wlan-ng/prism2mgmt.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > > index 16fb2d3..64a9ebc 100644 > > --- a/drivers/staging/wlan-ng/prism2mgmt.c > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > > hw->sniffhdr = 0; > > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > > } else > > - if ((msg->wlanheader.status == > > - P80211ENUM_msgitem_status_data_ok) > > - && (msg->wlanheader.data == P80211ENUM_truth_true)) { > > + if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && > > + (msg->wlanheader.data == P80211ENUM_truth_true)) { > > hw->sniffhdr = 1; > > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > > } else { > > This patch has checkpatch.pl errors. Please always use checkpatch so > you don't get emails from grumpy maintainers telling you to fix the > checkpatch errors :) > > Please fix up and resend the whole series. > > thanks, > > greg k-h of course it has. Few patches ago I've sent all changes in one patch so there was no errors. Then You asked me to break up every change to particular commits, so there are checkpatch errors between them. PATCH 3/3 solves all errors. So how should I commit this changes, finally? I feel bit lost.