From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752947AbdBOTHA (ORCPT ); Wed, 15 Feb 2017 14:07:00 -0500 Received: from mga03.intel.com ([134.134.136.65]:41653 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbdBOTG6 (ORCPT ); Wed, 15 Feb 2017 14:06:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,166,1484035200"; d="scan'208";a="934301173" Date: Wed, 15 Feb 2017 21:06:48 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Message-ID: <20170215190648.w5i3fkkjvmipzbeb@intel.com> References: <20170215180228.25650-1-jarkko.sakkinen@linux.intel.com> <20170215185643.GG19162@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215185643.GG19162@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 11:56:43AM -0700, Jason Gunthorpe wrote: > On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > > There's no need to export tpm2_get_pcr_alloation() because it is only > > a helper function for tpm2_auto_startup(). For the same reason it does > > not make much sense to maintain documentation for it. > > Please stop moving these functions around, you are just breaking the > git history and git blame - there cosmetic reason of having a certain > order is not worth this damage. > > Jason So you rather want a predeclaration? Moving code for the right reasons is perfectly justifiable. /Jarkko