From: Shaohua Li <shli@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <tom.leiming@gmail.com>, Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev()
Date: Wed, 15 Feb 2017 11:20:25 -0800 [thread overview]
Message-ID: <20170215192025.fo7jsew7pvagp5hv@kernel.org> (raw)
In-Reply-To: <20170214160109.GA32705@infradead.org>
On Tue, Feb 14, 2017 at 08:01:09AM -0800, Christoph Hellwig wrote:
> On Tue, Feb 14, 2017 at 11:29:03PM +0800, Ming Lei wrote:
> > Firstly bio_clone_mddev() is used in raid normal I/O and isn't
> > in resync I/O path.
> >
> > Secondly all the direct access to bvec table in raid happens on
> > resync I/O except for write behind of raid1, in which we still
> > use bio_clone() for allocating new bvec table.
> >
> > So this patch replaces bio_clone() with bio_clone_fast()
> > in bio_clone_mddev().
> >
> > Also kill bio_clone_mddev() and call bio_clone_fast() directly, as
> > suggested by Christoph Hellwig.
> >
> > Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Btw, can you also tack on another patch to kill bio_alloc_mddev
> to be consistent?
I'll take care of this
next prev parent reply other threads:[~2017-02-15 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:28 [PATCH v2 0/5] md: use bio_clone_fast() Ming Lei
2017-02-14 15:28 ` [PATCH v2 1/5] block: introduce bio_clone_bioset_partial() Ming Lei
2017-02-14 15:29 ` [PATCH v2 2/5] md: fail if mddev->bio_set can't be created Ming Lei
2017-02-14 15:29 ` [PATCH v2 3/5] md/raid1: use bio_clone_bioset_partial() in case of write behind Ming Lei
2017-02-14 15:29 ` [PATCH v2 4/5] md: remove unnecessary check on mddev Ming Lei
2017-02-14 15:29 ` [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev() Ming Lei
2017-02-14 16:01 ` Christoph Hellwig
2017-02-15 19:20 ` Shaohua Li [this message]
2017-02-15 23:19 ` Shaohua Li
2017-02-14 15:31 ` [PATCH v2 0/5] md: use bio_clone_fast() Jens Axboe
2017-02-15 19:19 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215192025.fo7jsew7pvagp5hv@kernel.org \
--to=shli@kernel.org \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®