From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297AbdBPCpm (ORCPT ); Wed, 15 Feb 2017 21:45:42 -0500 Received: from smtprelay0036.hostedemail.com ([216.40.44.36]:41583 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751732AbdBPCpl (ORCPT ); Wed, 15 Feb 2017 21:45:41 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3872:3874:4250:5007:6261:7875:7974:10004:10400:10848:10967:11026:11232:11658:11914:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21325:21451:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: slave25_1427eddba6a53 X-Filterd-Recvd-Size: 1739 Date: Wed, 15 Feb 2017 21:45:37 -0500 From: Steven Rostedt To: Byungchul Park Cc: , , , , Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Message-ID: <20170215214537.7936f336@grimm.local.home> In-Reply-To: <1487212457-28839-2-git-send-email-byungchul.park@lge.com> References: <1487212457-28839-1-git-send-email-byungchul.park@lge.com> <1487212457-28839-2-git-send-email-byungchul.park@lge.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Feb 2017 11:34:17 +0900 Byungchul Park wrote: > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when > it returns a task other than NULL, which means that task_cpu(task) must > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be > rq->cpu as well. Remove the redundant condition and make code simpler. > > By this patch, unnecessary one branch and two LOAD operations in 'if' > statement can be avoided. > > Signed-off-by: Byungchul Park > Reviewed-by: Steven Rostedt (VMware) > Reviewed-by: Juri Lelli > --- This is a different patch, I don't believe Juri reviewed it yet. -- Steve