From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752765AbdBOWMz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Feb 2017 17:12:55 -0500
Received: from vps0.lunn.ch ([178.209.37.122]:41005 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752634AbdBOWMy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Feb 2017 17:12:54 -0500
Date: Wed, 15 Feb 2017 23:12:49 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: mdf@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        moritz.fischer@ettus.com, Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality
Message-ID: <20170215221249.GB6096@lunn.ch>
References: <1487191445-5353-1-git-send-email-mdf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1487191445-5353-1-git-send-email-mdf@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
>  		macb_get_hwaddr(bp);
>  
>  	/* Power up the PHY if there is a GPIO reset */
> -	phy_node =  of_get_next_available_child(np, NULL);
> -	if (phy_node) {
> +	phy_node = of_parse_phandle(np, "phy-handle", 0);
> +	if (!phy_node && of_phy_is_fixed_link(np)) {
> +		err = of_phy_register_fixed_link(np);

Hi Moritz

I don't see any calls to of_phy_deregister_fixed_link(), either in the
error path, or the remove code.

      Andrew