From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbdBPDD2 (ORCPT ); Wed, 15 Feb 2017 22:03:28 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:49167 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdBPDD1 (ORCPT ); Wed, 15 Feb 2017 22:03:27 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Thu, 16 Feb 2017 12:03:02 +0900 From: Byungchul Park To: Steven Rostedt Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Message-ID: <20170216030302.GU16086@X58A-UD3R> References: <1487212457-28839-1-git-send-email-byungchul.park@lge.com> <1487212457-28839-2-git-send-email-byungchul.park@lge.com> <20170215214537.7936f336@grimm.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215214537.7936f336@grimm.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 09:45:37PM -0500, Steven Rostedt wrote: > On Thu, 16 Feb 2017 11:34:17 +0900 > Byungchul Park wrote: > > > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when > > it returns a task other than NULL, which means that task_cpu(task) must > > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be > > rq->cpu as well. Remove the redundant condition and make code simpler. > > > > By this patch, unnecessary one branch and two LOAD operations in 'if' > > statement can be avoided. > > > > Signed-off-by: Byungchul Park > > Reviewed-by: Steven Rostedt (VMware) > > Reviewed-by: Juri Lelli > > --- > > This is a different patch, I don't believe Juri reviewed it yet. I will take care not to make this kind of mistake next time. Thank you very much. > > -- Steve