From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755851AbdBOXnR (ORCPT ); Wed, 15 Feb 2017 18:43:17 -0500 Received: from mail.kernel.org ([198.145.29.136]:45836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755838AbdBOXnO (ORCPT ); Wed, 15 Feb 2017 18:43:14 -0500 Date: Thu, 16 Feb 2017 08:43:04 +0900 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Ananth N Mavinakayanahalli , Arnaldo Carvalho de Melo , Ingo Molnar , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] trace/kprobes: allow return probes with offsets and absolute addresses Message-Id: <20170216084304.352c744cc2bf26ed16170033@kernel.org> In-Reply-To: References: <20170215175346.GE3169@naverao1-tp.localdomain> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2017 23:47:53 +0530 "Naveen N. Rao" wrote: > Since the kernel includes many non-global functions with same names, we > will need to use offsets from other symbols (typically _text/_stext) or > absolute addresses to place return probes on specific functions. Also, > the core register_kretprobe() API never forbid use of offsets or > absolute addresses with kretprobes. > > Allow its use with the trace infrastructure. > OK, Looks good to me. Acked-by: Masami Hiramatsu Thanks! > Signed-off-by: Naveen N. Rao > --- > kernel/trace/trace_kprobe.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 7ad9e53ad174..2768cb60ebd7 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -679,10 +679,6 @@ static int create_trace_kprobe(int argc, char **argv) > return -EINVAL; > } > if (isdigit(argv[1][0])) { > - if (is_return) { > - pr_info("Return probe point must be a symbol.\n"); > - return -EINVAL; > - } > /* an address specified */ > ret = kstrtoul(&argv[1][0], 0, (unsigned long *)&addr); > if (ret) { > @@ -698,10 +694,6 @@ static int create_trace_kprobe(int argc, char **argv) > pr_info("Failed to parse symbol.\n"); > return ret; > } > - if (offset && is_return) { > - pr_info("Return probe must be used without offset.\n"); > - return -EINVAL; > - } > } > argc -= 2; argv += 2; > > -- > 2.11.0 > -- Masami Hiramatsu