From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] cpufreq: schedutil: govern how frequently we change frequency with rate_limit
Date: Thu, 16 Feb 2017 13:36:05 +0100 [thread overview]
Message-ID: <20170216123605.GA6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170216101210.GD21911@vireshk-i7>
On Thu, Feb 16, 2017 at 03:42:10PM +0530, Viresh Kumar wrote:
> But when I discussed this with Vincent, he suggested that it may not be required
> at all as the scheduler (with the helped of "decayed") doesn't call into
> schedutil too often, i.e. at least 1 ms. And if the CPUs are stable enough (i.e.
> no interruptions to the running task), we wouldn't reevaluate before the next
> tick.
There are still the attach/detach callers to cfs_rq_util_change() that
kick in for fork/exit and migration.
But yes, barring those we shouldn't end up calling it at silly rates.
next prev parent reply other threads:[~2017-02-16 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 17:15 Viresh Kumar
2017-02-15 22:35 ` Rafael J. Wysocki
2017-02-15 22:52 ` Rafael J. Wysocki
2017-02-16 0:02 ` Rafael J. Wysocki
2017-02-16 10:12 ` Viresh Kumar
2017-02-16 12:36 ` Peter Zijlstra [this message]
2017-02-17 12:15 ` Rafael J. Wysocki
2017-02-17 12:48 ` Peter Zijlstra
2017-02-20 9:58 ` Viresh Kumar
2017-02-20 13:49 ` Rafael J. Wysocki
2017-02-20 14:53 ` Rafael J. Wysocki
2017-02-16 6:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216123605.GA6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome