mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
	thomas@winischhofer.net, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code
Date: Thu, 16 Feb 2017 08:39:19 -0800	[thread overview]
Message-ID: <20170216163919.GB30538@kroah.com> (raw)
In-Reply-To: <1487240929.22685.19.camel@suse.com>

On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote:
> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva:
> > The condition modex % 16 cannot be true when modex value is equal to
> > 640
> > The condition du & 0xff cannot be true when du value is equal to
> > 0x1400
> > 
> 
> Sorry for speaking up so late, but this is not a good idea.
> We lose the knowledge how to do this correctly, if we want
> to change the resolution.

Given the age of this driver, I doubt that will ever happen :)

thanks,

greg k-h

  reply	other threads:[~2017-02-16 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08  4:01 Gustavo A. R. Silva
2017-02-16 10:28 ` Oliver Neukum
2017-02-16 16:39   ` Greg KH [this message]
2017-02-16 20:59     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216163919.GB30538@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=garsilva@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®