From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932916AbdBQIl1 (ORCPT ); Fri, 17 Feb 2017 03:41:27 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60953 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755703AbdBQIjJ (ORCPT ); Fri, 17 Feb 2017 03:39:09 -0500 Date: Thu, 16 Feb 2017 19:48:18 +0100 From: Maxime Ripard To: Corentin Labbe Cc: peppe.cavallaro@st.com, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, alexandre.torgue@st.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 04/21] ARM: sun8i: dt: Add DT bindings documentation for Allwinner dwmac-sun8i Message-ID: <20170216184818.hwexzuqacbemsxo7@lukather> References: <20170216124859.14346-1-clabbe.montjoie@gmail.com> <20170216124859.14346-5-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r2d7za65jyewaw3i" Content-Disposition: inline In-Reply-To: <20170216124859.14346-5-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r2d7za65jyewaw3i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Feb 16, 2017 at 01:48:42PM +0100, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner dwmac-sun8i driver. >=20 > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt | 86 ++++++++++++++++= ++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/dwmac-sun8i.txt >=20 > diff --git a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt b/Docu= mentation/devicetree/bindings/net/dwmac-sun8i.txt > new file mode 100644 > index 0000000..ac806c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt > @@ -0,0 +1,86 @@ > +* Allwinner sun8i GMAC ethernet controller > + > +This device is a platform glue layer for stmmac. > +Please see stmmac.txt for the other unchanged properties. > + > +Required properties: > +- compatible: should be one of the following string: > + "allwinner,sun8i-a83t-emac" > + "allwinner,sun8i-h3-emac" > + "allwinner,sun50i-a64-emac" > +- reg: address and length of the register for the device. > +- interrupts: interrupt for the device > +- interrupt-names: should be "macirq" > +- clocks: A phandle to the reference clock for this device > +- clock-names: should be "stmmaceth" > +- resets: A phandle to the reset control for this device > +- reset-names: should be "stmmaceth" > +- phy-mode: See ethernet.txt > +- phy-handle: See ethernet.txt > +- #address-cells: shall be 1 > +- #size-cells: shall be 0 > +- syscon: A phandle to the syscon of the SoC with one of the following > + compatible string: > + - allwinner,sun8i-h3-system-controller > + - allwinner,sun8i-a64-system-controller > + - allwinner,sun8i-a83t-system-controller > + > +Optional properties: > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07.= Default is 0) > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F.= Default is 0) > +Both delay properties does not have units, there are arbitrary value. > +The TX/RX clock delay chain settings are board specific and could be fou= nd > +in vendor FEX files. > + > +Optional properties for "allwinner,sun8i-h3-emac": > +- allwinner,leds-active-low: EPHY LEDs are active low > + > +Required child node of emac: > +- mdio bus node: should be named mdio > + > +Required properties of the mdio node: > +- #address-cells: shall be 1 > +- #size-cells: shall be 0 > + > +The device node referenced by "phy" or "phy-handle" should be a child no= de > +of the mdio node. See phy.txt for the generic PHY bindings. > + > +Required properties of the phy node with "allwinner,sun8i-h3-emac": > +- clocks: an extra phandle to the reference clock for the EPHY > +- resets: an extra phandle to the reset control for the EPHY > + > +Required properties for the system controller: > +- reg: address and length of the register for the device. > +- compatible: should be "syscon" and one of the following string: > + "allwinner,sun8i-h3-system-controller" > + "allwinner,sun8i-a64-system-controller" > + "allwinner,sun8i-a83t-system-controller" This should be in a separate binding document. What does it describe / represent? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --r2d7za65jyewaw3i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYpfPyAAoJEBx+YmzsjxAgqbcP/1bSyaEw8ZKYYxt7xJm+mand U4H4r8QLkvchV4u2eSmVlIaRYUeqDLbgvSizrKjtA6Sk7KIJG19qSwOsr7jxa24M h18DTb+I28EKyroCDGq0fpzYgZPXMmijV0InMVqC/2qpZAQDjsIQA9e4w52lJP+p aAhKPLgE0FOjtDIQs/ebDsDWCDDYxNk91Ltuah5i2FIF8X3tABqFKcjvfiHkLg7o tRaIqRKv/i7O8bUcQEgyVbuUmzS98ADN8T+mGjjcNJo7qNHvyME4xXBl5UjMp/BA 5htGpk34uJBm2EJ34XPLuZVONTRZMznl+lScpuSV9Q0JB8SNz8phx4aepgTwTc01 XvTcRR45HpeTlkOFSku61Zv1F/C5xu8k22rnWswYChrtG/8UDloC1hbsscFSO5XO nG5xqV9Lf+ZPtLzhb3+7C4SUYkMe+vNyOPD8zPQbgXEPfPycFiMOVHbUcnb5yEZS cFQWiXQmXDukC45GZ5xj70jC5vo8KaTqJWe0zbWq2XJyO/uZRGHrPsJXr/TwqEDc iqlNPw8ZTduP8bnTPvtFbdK/T+utd3I4q3J2/TEcS5OuctjBwV9PY3GUXjq74kuw +LuQgnwMKmwFHfF8ZEf9IlehQOmJKQLXlIo/j5z9oHATU9iDdZqfoWHkfXnn1gTx qwHBt7phbnMz3VpH1qx0 =zovr -----END PGP SIGNATURE----- --r2d7za65jyewaw3i--