From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756048AbdBQIkz (ORCPT ); Fri, 17 Feb 2017 03:40:55 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60972 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755749AbdBQIjJ (ORCPT ); Fri, 17 Feb 2017 03:39:09 -0500 Date: Thu, 16 Feb 2017 20:06:32 +0100 From: Maxime Ripard To: Corentin Labbe Cc: peppe.cavallaro@st.com, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, alexandre.torgue@st.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins Message-ID: <20170216190632.hezcacn3hw5uhxcn@lukather> References: <20170216124859.14346-1-clabbe.montjoie@gmail.com> <20170216124859.14346-9-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="62ryoqpqlfab5l3f" Content-Disposition: inline In-Reply-To: <20170216124859.14346-9-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --62ryoqpqlfab5l3f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote: > This patch add pinctrl node for dwmac-sun8i on H3. >=20 > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3= =2Edtsi > index 61d56d2..59ed40e 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -349,6 +349,17 @@ > function =3D "i2c2"; > }; > =20 > + emac_rgmii_pins: emac0@0 { > + allwinner,pins =3D "PD0", "PD1", "PD2", "PD3", > + "PD4", "PD5", "PD7", > + "PD8", "PD9", "PD10", > + "PD12", "PD13", "PD15", > + "PD16", "PD17"; > + allwinner,function =3D "emac"; Please use the generic pin config properties (ie. pins and functions). > + allwinner,drive =3D ; Why do you need to use 40mA? > + allwinner,pull =3D ; This is the default now. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --62ryoqpqlfab5l3f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYpfg4AAoJEBx+YmzsjxAgT5EP/2eTqruWbK/GDeRRhDfLr53P WPhDbeITREn7LqkFA1dCCdAzvcioHfH8WqWaNQtMcYIvxmxvFGrB8KoKEVtQHVQX hoWANjwuHSx0ro2P02u0f/PuDkj2cAYONH8HDO7i5Eenvn0K4VU6au12tskOoIOK jn6jZdj4KZWUXMyCyyBapxx967E5Xz0N3tynCsalWw3AGKZ2LSESRYoHhZHdpIIZ UrofW96xtn7WTm6w4s8i6XnDALrX1ImvHuXVBdEfrcDhp9JjRq76mn0uG9+2OKKy mnKjDwdzHz1lHdF4Wv8ZIH5SN2X/W/wDgU9G7A8DO/UQ1iH/S2u4iwbgLFRu7rrQ D+mkkU2GVeCh/ZR4eep7nKW1UQc1rc+fVWD+I4H/0J12hcCuv85jPR+pyPb9YcD6 eLaZmzKjSA1rO03s0SES4RDVFTX2ko9KWydsTY7yXj0tO7W0fBj0ltWLLKhE/edY EqBrg1pE7FbNH5gKnAbjiEkuCFLsTSC8puM/U9tuapLXLVxpn85T2ft5aLR6cIpr Od1788R9/HXz2G3mFXhORzKZlneEWLZYW/5BVr4PfWpe1wIu0wjYU6kEZJe/NQ3s Lx/WeifSMfK2mTdYbTTquYMOw9Rh65UD2ZZel42LeEzxIWZ2rfAKsg8TqkeKmToC 5vjP/bb4hZM6FmwRGR33 =WYCD -----END PGP SIGNATURE----- --62ryoqpqlfab5l3f--