From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755334AbdBQCA2 (ORCPT ); Thu, 16 Feb 2017 21:00:28 -0500 Received: from smtprelay0193.hostedemail.com ([216.40.44.193]:50277 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755077AbdBQCA1 (ORCPT ); Thu, 16 Feb 2017 21:00:27 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:7514:7875:9025:10004:10400:10848:10967:11026:11232:11257:11658:11914:12043:12296:12438:12555:12700:12737:12740:12760:12895:13069:13161:13229:13311:13357:13439:14096:14097:14106:14181:14659:14721:14849:21080:21324:21451:30054:30060:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: level23_7807120c15941 X-Filterd-Recvd-Size: 2503 Date: Thu, 16 Feb 2017 21:00:23 -0500 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Namhyung Kim , Jiri Olsa , Linux Kernel Mailing List Subject: Re: [PATCH] building libtraceevent with clang Message-ID: <20170216210023.5c39de2f@grimm.local.home> In-Reply-To: <20170213172020.GE6473@kernel.org> References: <20170210170317.GA14313@kernel.org> <20170210141408.5eeb6e91@gandalf.local.home> <20170213162455.GB6473@kernel.org> <20170213162622.GC6473@kernel.org> <20170213121418.47f279e8@gandalf.local.home> <20170213172020.GE6473@kernel.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Feb 2017 14:20:20 -0300 Arnaldo Carvalho de Melo wrote: > Cc: Adrian Hunter > Cc: David Ahern > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Wang Nan > Link: http://lkml.kernel.org/n/tip-b5wyjocel55gorl2jq2cbxrr@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > > diff --git a/tools/lib/traceevent/plugin_function.c b/tools/lib/traceevent/plugin_function.c > index a00ec190821a..42dbf73758f3 100644 > --- a/tools/lib/traceevent/plugin_function.c > +++ b/tools/lib/traceevent/plugin_function.c > @@ -130,7 +130,7 @@ static int function_handler(struct trace_seq *s, struct pevent_record *record, > unsigned long long pfunction; > const char *func; > const char *parent; > - int index; > + int index = 0; I went to apply this to trace-cmd's version, and it failed to apply. Then I realized that I had this fixed back in 2015, but missed sending it. That's because I don't strictly follow the 80 column limit for some of the if statements (I find the break up ugly), and when doing diffs, this got lost in the diffs of the 80 column limits ones done with the port to the kernel tree. :-/ -- Steve > > if (pevent_get_field_val(s, event, "ip", record, &function, 1)) > return trace_seq_putc(s, '!'); >