From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933714AbdBPWss (ORCPT ); Thu, 16 Feb 2017 17:48:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:35472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933157AbdBPWsr (ORCPT ); Thu, 16 Feb 2017 17:48:47 -0500 Date: Thu, 16 Feb 2017 14:48:43 -0800 From: Shaohua Li To: Byungchul Park Cc: peterz@infradead.org, mingo@kernel.org, neilb@suse.de, nab@linux-iscsi.org, viro@zeniv.linux.org.uk, ying.huang@intel.com, oleg@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/9] raid5: Don't reinvent the wheel but use existing llist API Message-ID: <20170216224843.f76zr4fbyxgmb6t7@kernel.org> References: <1487057190-25191-1-git-send-email-byungchul.park@lge.com> <1487057190-25191-4-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487057190-25191-4-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 04:26:24PM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. This one has no dependence of previous patches, so I added to md tree. Thanks, Shaohua > Signed-off-by: Byungchul Park > --- > drivers/md/raid5.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 36c13e4..22a0326 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -353,17 +353,15 @@ static void release_inactive_stripe_list(struct r5conf *conf, > static int release_stripe_list(struct r5conf *conf, > struct list_head *temp_inactive_list) > { > - struct stripe_head *sh; > + struct stripe_head *sh, *t; > int count = 0; > struct llist_node *head; > > head = llist_del_all(&conf->released_stripes); > head = llist_reverse_order(head); > - while (head) { > + llist_for_each_entry_safe(sh, t, head, release_list) { > int hash; > > - sh = llist_entry(head, struct stripe_head, release_list); > - head = llist_next(head); > /* sh could be readded after STRIPE_ON_RELEASE_LIST is cleard */ > smp_mb(); > clear_bit(STRIPE_ON_RELEASE_LIST, &sh->state); > -- > 1.9.1 >