From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933708AbdBPW53 (ORCPT ); Thu, 16 Feb 2017 17:57:29 -0500 Received: from skprod2.natinst.com ([130.164.80.23]:35093 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933157AbdBPW52 (ORCPT ); Thu, 16 Feb 2017 17:57:28 -0500 From: Julia Cartwright To: Steven Rostedt CC: , Jan Kiszka Subject: [PATCH] trace-cmd: fixup more bogus symbol resolutions Date: Thu, 16 Feb 2017 16:57:21 -0600 Message-ID: <20170216225721.13087-1-julia@ni.com> X-Mailer: git-send-email 2.11.1 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-16_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702160215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit ce1cbc51c ("trace-cmd: Leave out absolute addresses to fix bogus symbol resolutions") fixed up bogus symbol resolution for 'A' type symbols used on x86_64 for percpu offsets. However, this check did not cover per-cpu variables used in modules, which are generated as 'local' absolute symbols, and therefore appear as 'a' in /proc/kallsyms. Fix this. Cc: Jan Kiszka Signed-off-by: Julia Cartwright --- trace-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-util.c b/trace-util.c index 5bf591c..fc5926e 100644 --- a/trace-util.c +++ b/trace-util.c @@ -458,7 +458,7 @@ void parse_proc_kallsyms(struct pevent *pevent, * - arm arch that adds a lot of bogus '$a' functions * - x86-64 that reports per-cpu variable offsets as absolute */ - if (func[0] != '$' && ch != 'A') + if (func[0] != '$' && ch != 'A' && ch != 'a') pevent_register_function(pevent, func, addr, mod); free(func); free(mod); -- 2.11.1