From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbdBQAhy (ORCPT ); Thu, 16 Feb 2017 19:37:54 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:36342 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbdBQAhw (ORCPT ); Thu, 16 Feb 2017 19:37:52 -0500 Date: Thu, 16 Feb 2017 18:37:49 -0600 From: Andy Gross To: Bjorn Andersson Cc: Ohad Ben-Cohen , David Brown , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Dan Carpenter , Stanimir Varbanov Subject: Re: [PATCH] remoteproc: qcom: mdt_loader: Use signed type for offset Message-ID: <20170217003749.GB29050@hector.attlocal.net> References: <20170215220041.3077-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215220041.3077-1-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 02:00:41PM -0800, Bjorn Andersson wrote: > In the transition from using rproc_da_to_va(), the type of the load > offset became unsigned. This causes the subsequent check to let negative > values less than p_memsz + mem_size through and we write outside of the > buffer. > > Change the type back to a signed value to catch this. > > Fixes: 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader") > Fixes: e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader") > Reported-by: Dan Carpenter > Reported-by: Stanimir Varbanov > Signed-off-by: Bjorn Andersson Acked-by: Andy Gross