From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
David Airlie <airlied@linux.ie>
Cc: Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] drm/sun4i: Check return value of drm_vblank_init
Date: Fri, 17 Feb 2017 11:13:26 +0800 [thread overview]
Message-ID: <20170217031330.14087-4-wens@csie.org> (raw)
In-Reply-To: <20170217031330.14087-1-wens@csie.org>
drm_vblank_init can fail due to insufficient memory. Ignoring the error
and proceeding may cause the kernel to dereference an invalid pointer
when vblank is enabled.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 8e777167bca4..63c46643fdd1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -130,7 +130,11 @@ static int sun4i_drv_bind(struct device *dev)
}
drm->dev_private = drv;
- drm_vblank_init(drm, 1);
+ /* drm_vblank_init calls kcalloc, which can fail */
+ ret = drm_vblank_init(drm, 1);
+ if (ret)
+ goto free_drm;
+
drm_mode_config_init(drm);
ret = component_bind_all(drm->dev, drm);
--
2.11.0
next prev parent reply other threads:[~2017-02-17 3:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 3:13 [PATCH 0/7] drm/sun4i: Various fixes and cleanups part 1 Chen-Yu Tsai
2017-02-17 3:13 ` [PATCH 1/7] drm/sun4i: Move drm_mode_config_cleanup call to main driver Chen-Yu Tsai
2017-02-21 20:19 ` Maxime Ripard
2017-02-17 3:13 ` [PATCH 2/7] drm/sun4i: Fix up error path cleanup for master bind function Chen-Yu Tsai
2017-02-21 20:20 ` Maxime Ripard
2017-02-17 3:13 ` Chen-Yu Tsai [this message]
2017-02-21 22:11 ` [PATCH 3/7] drm/sun4i: Check return value of drm_vblank_init Maxime Ripard
2017-02-17 3:13 ` [PATCH 4/7] drm/sun4i: Fix kcalloc element size in sun4i_layers_init Chen-Yu Tsai
2017-02-21 22:12 ` Maxime Ripard
2017-02-17 3:13 ` [PATCH 5/7] drm/sun4i: Drop useless assignment " Chen-Yu Tsai
2017-02-21 22:12 ` Maxime Ripard
2017-02-17 3:13 ` [PATCH 6/7] drm/sun4i: Save newly created layer in layers array " Chen-Yu Tsai
2017-02-21 22:12 ` Maxime Ripard
2017-02-17 3:13 ` [PATCH 7/7] drm/sun4i: Make sun4i_crtc_init return ERR_PTR style error codes Chen-Yu Tsai
2017-02-21 22:13 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217031330.14087-4-wens@csie.org \
--to=wens@csie.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®