From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934807AbdBQSmq (ORCPT ); Fri, 17 Feb 2017 13:42:46 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54724 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934507AbdBQSmp (ORCPT ); Fri, 17 Feb 2017 13:42:45 -0500 Date: Fri, 17 Feb 2017 10:42:42 -0800 From: Greg Kroah-Hartman To: Lucas Stach Cc: linux-kernel@vger.kernel.org, patchwork-lst@pengutronix.de, kernel@pengutronix.de Subject: Re: [PATCH] driver core: unbind consumers before locking parent on device unbind Message-ID: <20170217184242.GA11935@kroah.com> References: <20170217183629.3628-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217183629.3628-1-l.stach@pengutronix.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 07:36:29PM +0100, Lucas Stach wrote: > On forced unbind the parent lock is taken, as the device might be a USB > device. The device to be unbound might have active consumers, which > must be unbound before calling device_release_driver(), otherwise this > function might deadlock when trying to take the parent lock during > consumer unbind. Really? What type of device does this fail on today? thanks, greg k-h