From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934883AbdBQSn3 (ORCPT ); Fri, 17 Feb 2017 13:43:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54742 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934507AbdBQSn2 (ORCPT ); Fri, 17 Feb 2017 13:43:28 -0500 Date: Fri, 17 Feb 2017 10:43:25 -0800 From: Greg Kroah-Hartman To: Nathan Howard Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stephen Warren , Lee Jones , Eric Anholt , Michael Zoran , devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues Message-ID: <20170217184325.GB11935@kroah.com> References: <1487356776-11449-1-git-send-email-adanhawthorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487356776-11449-1-git-send-email-adanhawthorn@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 01:39:07PM -0500, Nathan Howard wrote: > The following coding style issues (as per checkpatch.pl) were resolved. > > WARNING: Block comments use * on subsequent lines > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... > WARNING: Missing a blank line after declarations > WARNING: Use of volatile is usually wrong:... > WARNING: line over 80 characters > CHECK: Concatenated strings should use spaces between elements > CHECK: Macro argument 'vol' may be better as '(vol)' to avoid precedence issues Please only do one thing per patch, and no, "fix style issues" is not one thing :( This should be a patch series, one per type of thing done. thanks, greg k-h