From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbdBRNIl (ORCPT ); Sat, 18 Feb 2017 08:08:41 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44062 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbdBRNIi (ORCPT ); Sat, 18 Feb 2017 08:08:38 -0500 Date: Sat, 18 Feb 2017 14:06:50 +0100 From: Greg Kroah-Hartman To: Maarten Brock Cc: Shailendra Verma , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , linux-serial-owner@vger.kernel.org Subject: Re: [PATCH] Tty: serial - Fix possible NULL derefrence. Message-ID: <20170218130650.GB24938@kroah.com> References: <1485515773-3542-1-git-send-email-shailendra.v@samsung.com> <20170130193743.GB27138@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 18, 2017 at 11:25:19AM +0100, Maarten Brock wrote: > Hello Greg, > > Does that also mean that this isn't possible in the sc16is7xx.c driver in > sc16is7xx_spi_probe() line 1358 and sc16is7xx_i2c_probe() line 1419 ? > > If so, should these checks be removed? Probably.