From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbdBTPTz (ORCPT ); Mon, 20 Feb 2017 10:19:55 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38206 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753010AbdBTPTx (ORCPT ); Mon, 20 Feb 2017 10:19:53 -0500 Date: Mon, 20 Feb 2017 10:19:51 -0500 (EST) Message-Id: <20170220.101951.663166903772216217.davem@davemloft.net> To: santosh.shilimkar@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header From: David Miller In-Reply-To: <1487387747-5324-1-git-send-email-santosh.shilimkar@oracle.com> References: <1487387747-5324-1-git-send-email-santosh.shilimkar@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Feb 2017 06:20:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Santosh Shilimkar Date: Fri, 17 Feb 2017 19:15:47 -0800 > From: Santosh Shilimkar > > rds.h is exported to /usr/include/rds.h, so u8, u64 leads to > errors like below. > > /usr/include/linux/rds.h:197: error: expected specifier-qualifier-list before 'u8' > /usr/include/linux/rds.h:202: error: expected specifier-qualifier-list before 'u8' > > Fix it by following same types as rest of the user header. > > Reported-by: Sowmini Varadhan > Signed-off-by: Santosh Shilimkar The correct fix it to use "__u8", "__u64", etc.