From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbdBTVax (ORCPT ); Mon, 20 Feb 2017 16:30:53 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:40728 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbdBTVav (ORCPT ); Mon, 20 Feb 2017 16:30:51 -0500 Date: Mon, 20 Feb 2017 23:30:43 +0200 From: Sakari Ailus To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Pavel Machek , linux-media@vger.kernel.org Subject: Re: [PATCH] [media] et8ek8: Export OF device ID as module aliases Message-ID: <20170220213043.GW16975@valkosipuli.retiisi.org.uk> References: <20170220201616.15028-1-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220201616.15028-1-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 20, 2017 at 05:16:16PM -0300, Javier Martinez Canillas wrote: > The I2C core always reports a MODALIAS of the form i2c: even if the > device was registered via OF, this means that exporting the OF device ID > table device aliases in the module is not needed. But in order to change > how the core reports modaliases to user-space, it's better to export it. > > Before this patch: > > $ modinfo drivers/media/i2c/et8ek8/et8ek8.ko | grep alias > alias: i2c:et8ek8 > > After this patch: > > $ modinfo drivers/media/i2c/et8ek8/et8ek8.ko | grep alias > alias: i2c:et8ek8 > alias: of:N*T*Ctoshiba,et8ek8C* > alias: of:N*T*Ctoshiba,et8ek8 > > Signed-off-by: Javier Martinez Canillas Thanks! Applied to my tree (for-v4.12 branch). -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk