From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753364AbdBUNoo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Feb 2017 08:44:44 -0500
Received: from mail-lf0-f66.google.com ([209.85.215.66]:33859 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752574AbdBUNoi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Feb 2017 08:44:38 -0500
Date: Tue, 21 Feb 2017 14:44:36 +0100
From: Johan Hovold <johan@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: simran singhal <singhalsimran0@gmail.com>, johan@kernel.org,
        elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 3/6] staging: greybus: Remove
 unnecessary braces
Message-ID: <20170221134436.GB10245@localhost>
References: <20170221131535.GA3718@singhal-Inspiron-5558>
 <alpine.DEB.2.20.1702211420300.3121@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1702211420300.3121@hadrien>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 21, 2017 at 02:20:50PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 21 Feb 2017, simran singhal wrote:
> 
> > This patch removes braces for single statement blocks. The warning
> > was detected using checkpatch.pl.
> > Coccinelle was used to make the change.
> >
> > @@
> > expression e,e1;
> > @@
> > - if (e) {
> > + if (e)
> >   e1;
> > - }
> >
> > Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

I do not think this patch should be merged.

Note that all of the braces you are removing are for single statements
that span multiple lines, and that is precisely why the braces were
added in the first place. Having braces for such statements often
increase readability even if they are not mandated by the coding
standard.

So I suggest this patch is dropped.

Thanks,
Johan