From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdBUPrH (ORCPT ); Tue, 21 Feb 2017 10:47:07 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:57238 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbdBUPqr (ORCPT ); Tue, 21 Feb 2017 10:46:47 -0500 Date: Tue, 21 Feb 2017 16:46:40 +0100 From: Peter Zijlstra To: Elena Reshetova Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, mark.rutland@arm.com, akpm@linux-foundation.org, matija.glavinic-pecotic.ext@nokia.com Subject: Re: [PATCH 0/9] tools subsystem refcounter conversions Message-ID: <20170221154640.GH6515@twins.programming.kicks-ass.net> References: <1487691303-31858-1-git-send-email-elena.reshetova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487691303-31858-1-git-send-email-elena.reshetova@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 05:34:54PM +0200, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the tools susystem from atomic_t > to refcount_t. By doing this we prevent intentional or accidental > underflows or overflows that can led to use-after-free vulnerabilities. > > The below patches are fully independent and can be cherry-picked separately. > Since we convert all kernel subsystems in the same fashion, resulting > in about 300 patches, we have to group them for sending at least in some > fashion to be manageable. Please excuse the long cc list. > > Elena Reshetova (9): > tools: convert cgroup_sel.refcnt from atomic_t to refcount_t > tools: convert cpu_map.refcnt from atomic_t to refcount_t > tools: convert comm_str.refcnt from atomic_t to refcount_t > tools: convert dso.refcnt from atomic_t to refcount_t > tools: convert map.refcnt from atomic_t to refcount_t > tools: convert map_groups.refcnt from atomic_t to refcount_t > tools: convert perf_map.refcnt from atomic_t to refcount_t > tools: convert thread.refcnt from atomic_t to refcount_t > tools: convert thread_map.refcnt from atomic_t to refcount_t > > tools/perf/util/cgroup.c | 6 +++--- > tools/perf/util/cgroup.h | 4 ++-- > tools/perf/util/comm.c | 13 +++++-------- > tools/perf/util/cpumap.c | 16 ++++++++-------- > tools/perf/util/cpumap.h | 4 ++-- > tools/perf/util/dso.c | 6 +++--- > tools/perf/util/dso.h | 4 ++-- > tools/perf/util/evlist.c | 18 +++++++++--------- > tools/perf/util/evlist.h | 4 ++-- > tools/perf/util/map.c | 10 +++++----- > tools/perf/util/map.h | 10 +++++----- > tools/perf/util/thread.c | 6 +++--- > tools/perf/util/thread.h | 4 ++-- > tools/perf/util/thread_map.c | 20 ++++++++++---------- > tools/perf/util/thread_map.h | 4 ++-- This is userspace code; did you build this? I see a distinct lack of adding refcount.h to the userspace headers.