From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbdBUWC2 (ORCPT ); Tue, 21 Feb 2017 17:02:28 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:60852 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbdBUWCR (ORCPT ); Tue, 21 Feb 2017 17:02:17 -0500 From: Arnd Bergmann To: Kees Cook , Hoeun Ryu Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] usercopy: ARM NOMMU has no 64-bit get_user Date: Tue, 21 Feb 2017 23:01:51 +0100 Message-Id: <20170221220204.225288-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:9oD+ayO07egiAckW9QHfZCN8++mwSJiOA/4fGP9xgZOOzRoCqR/ 7GogkkVEmg+PtvjGvhREFV3qYQYy25qwfo9WY+hHol/y6wmIcYIOLs1G0qUlEAd/2+vOinU TZIsvWwYYAHaaF4tNeRbYq97kadvWGXNQV3r/Uy6I8EMaVTmYvmx+59s9VvYZDv6gxC8OgL g9mVICv+HhHwlftFWhCDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q21DgszCQEQ=:r/5il7OWvukePQYqRaU8Jq vW5AhIuVK6KNIcNlm6yf9sZdI4eQZwz3G3BqWRyy9wDQRF2iJlJRgECOJi9S3bnyGB26wLyUs nGypEsr/2XK6UJfr9jq7ch3zewQzPpMaFj1cF70lr9wHOMVl042wguNI//9Ivcnhm2zoQJPKA 9S0MsSfwqKjleYsu3JawqaT2s99lxcOe+ioMr0kvJMeMfg86AZ23ojRZLN0SXexlhlHZeAvk4 ZLPfqKJlXpJQ/l4GhbJbxaYg8zv2fxkZ4m+LIxsaPFh9bu3bFTSIQLL+RGk535sZGoHzDVc7T tB/RtrDse2Wz1Cr/Fmij9iPPzdkzKMr3WCAuyYNgVZ7kpFkqimNRxFP64Nvmk4/2r8ZbAhUja J6sBfXkv5u7fdDNFik9rohIlrmkd2Pn7T/+g86xvByXaDha1B+eacy23qiEzki3h+YAsMQLmc 13cSteoGGlEX1YShE57Q1wS3qOodKknAw12tVRlfPiFQ2Yskdyi1bELaY/Z7V1BZl4tdNrQ5s xPo+37Uedv0nCYybrnJAKrD+NnmNhEvnOhP4El50EmDaE4Cgi3yavlBzBGgzwAngNVnpaEB57 KvRRm6jriHjIBccpIWUEy5UkHvJm9vlFhaHTLT2ODXurH+5aaYdQC2cl/S0WQEs4FnUTC37Qx 4XqrutKfxAGXMwAu9rJdr/hXpUYqH+9vw/br6OiRSr4o/Rf09XQyMRuRJM7HfRfnDDMI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On a NOMMU ARM kernel, we get this link error: ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined! The problem is that the extended get_user/put_user definitions were only added for the noral (MMU based) case. We could add it for NOMMU as well, but it seems easier to just not call it, since no other code needs it. Fixes: 075c4ea5363d ("usercopy: Add tests for all get_user() sizes") Signed-off-by: Arnd Bergmann --- lib/test_user_copy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/test_user_copy.c b/lib/test_user_copy.c index 4a79f2c1cd6e..361576b2cb3d 100644 --- a/lib/test_user_copy.c +++ b/lib/test_user_copy.c @@ -30,7 +30,8 @@ * As there doesn't appear to be anything that can safely determine * their capability at compile-time, we just have to opt-out certain archs. */ -#if BITS_PER_LONG == 64 || (!defined(CONFIG_AVR32) && \ +#if BITS_PER_LONG == 64 || (!(defined(CONFIG_ARM) && !defined(MMU)) && \ + !defined(CONFIG_AVR32) && \ !defined(CONFIG_BLACKFIN) && \ !defined(CONFIG_M32R) && \ !defined(CONFIG_M68K) && \ -- 2.9.0