From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbdBUWMl (ORCPT ); Tue, 21 Feb 2017 17:12:41 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:38110 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbdBUWMe (ORCPT ); Tue, 21 Feb 2017 17:12:34 -0500 Date: Tue, 21 Feb 2017 14:12:27 -0800 From: Maxime Ripard To: Chen-Yu Tsai Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] drm/sun4i: Drop useless assignment in sun4i_layers_init Message-ID: <20170221221227.vv7iwm23b5irnqji@lukather> References: <20170217031330.14087-1-wens@csie.org> <20170217031330.14087-6-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bcqmjaawibr5pt3y" Content-Disposition: inline In-Reply-To: <20170217031330.14087-6-wens@csie.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bcqmjaawibr5pt3y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 17, 2017 at 11:13:28AM +0800, Chen-Yu Tsai wrote: > The assignment found in the main loop in sun4i_layers_init: >=20 > struct sun4i_layer *layer =3D layers[i]; >=20 > is useless as it gets overwritten by the next line: >=20 > layer =3D sun4i_layer_init_one(drm, plane); >=20 > Drop the assignment. >=20 > Signed-off-by: Chen-Yu Tsai Applied, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --bcqmjaawibr5pt3y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYrLtLAAoJEBx+YmzsjxAg8qgP/jpWU8FgRsxGZTjbKbI9v7il aPd9UWF/ZECvGvF+6a6dxU7Uk+Lz9U62sPH7kBhC1RzLCGGXefdjdkLqd0L+wxVB V+nERHVCrJDlU0N+U+03l2gl4ltTyfOS+/ON5uT9EnTSDI4uZMccdx+HxVXXUD8i m613oVrXNH/VL//HDxC0/dKJmS6bctDU7GVVMhN7SvG9B8J/+5YN3XXYtrQApJGm s1/uMXwo3bSuAPCxaONem81EI5x0pE86z3HBSnVqp7U5ITO4V/Kf4taICMyvcqGv W8W+QVUX4rQKv8iLTu9NEjfKIUkmn+SQEcN7PdF8r78slrRAnZwmr4OkVqWdZVXP MTWgyMpOWg251DMhg7v7FRnOaRSGlhLkn/gL8Iu6w+chJeBxjfXkjnX6PT8C7S8t bu4TGfGUlwPI820JcEtQqEho9dHEJYoKY2OH5qh9EOK3k89pNp2kYVPZNlg7scmr l2MoSbAsrFCDcOZc4frYTnBlbLIK5aZjHgollYFLYaUAd5cgmCMTB6oxPNPq9/mK djOzZmc3lxiIwAEXLwq+5r6XODTOPgMJDuh07hKyZFS0thKPuVpg2JEY2ABV34dA exJQwlh+x3+wIyMZj91XZQFWQudcMicoJNMoVoKhuxua7vas9Nt7Yx5fNQLany2k jNzZnatbqb4UnU0+SsW5 =c13X -----END PGP SIGNATURE----- --bcqmjaawibr5pt3y--