From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934682AbdBVVPt (ORCPT ); Wed, 22 Feb 2017 16:15:49 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43466 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933512AbdBVVPm (ORCPT ); Wed, 22 Feb 2017 16:15:42 -0500 Date: Wed, 22 Feb 2017 16:15:38 -0500 (EST) Message-Id: <20170222.161538.2214724719402158538.davem@davemloft.net> To: aryabinin@virtuozzo.com Cc: gerrit@erg.abdn.ac.uk, edumazet@google.com, acme@kernel.org, dccp@vger.kernel.org, dvyukov@google.com, xiyou.wangcong@gmail.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kaber@trash.net, syzkaller@googlegroups.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/dccp: fix use after free in tw_timer_handler() From: David Miller In-Reply-To: <20170222093527.19698-1-aryabinin@virtuozzo.com> References: <20170221112740.661-1-aryabinin@virtuozzo.com> <20170222093527.19698-1-aryabinin@virtuozzo.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Feb 2017 12:16:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrey Ryabinin Date: Wed, 22 Feb 2017 12:35:27 +0300 > DCCP doesn't purge timewait sockets on network namespace shutdown. > So, after net namespace destroyed we could still have an active timer > which will trigger use after free in tw_timer_handler(): ... > Add .exit_batch hook to dccp_v4_ops()/dccp_v6_ops() which will purge > timewait sockets on net namespace destruction and prevent above issue. > > Fixes: f2bf415cfed7 ("mib: add net to NET_ADD_STATS_BH") > Reported-by: Dmitry Vyukov > Signed-off-by: Andrey Ryabinin > Acked-by: Arnaldo Carvalho de Melo Applied and queued up for -sable, thanks.