From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109AbdBVCBW (ORCPT ); Tue, 21 Feb 2017 21:01:22 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33386 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753710AbdBVCBO (ORCPT ); Tue, 21 Feb 2017 21:01:14 -0500 Date: Wed, 22 Feb 2017 07:31:09 +0530 From: simran singhal To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 3/7] staging: gdm724x: Drop useless initialisation Message-ID: <20170222020109.GA27876@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by: simran singhal --- drivers/staging/gdm724x/gdm_lte.c | 2 +- drivers/staging/gdm724x/gdm_mux.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index a182757..e0f0912 100644 --- a/drivers/staging/gdm724x/gdm_lte.c +++ b/drivers/staging/gdm724x/gdm_lte.c @@ -353,7 +353,7 @@ static s32 gdm_lte_tx_nic_type(struct net_device *dev, struct sk_buff *skb) struct ipv6hdr *ipv6; int mac_proto; void *network_data; - u32 nic_type = 0; + u32 nic_type; /* NIC TYPE is based on the nic_id of this net_device */ nic_type = 0x00000010 | nic->nic_id; diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index 4009691..aba32e2 100644 --- a/drivers/staging/gdm724x/gdm_mux.c +++ b/drivers/staging/gdm724x/gdm_mux.c @@ -62,7 +62,7 @@ static int packet_type_to_index(u16 packetType) static struct mux_tx *alloc_mux_tx(int len) { - struct mux_tx *t = NULL; + struct mux_tx *t; t = kzalloc(sizeof(*t), GFP_ATOMIC); if (!t) @@ -91,7 +91,7 @@ static void free_mux_tx(struct mux_tx *t) static struct mux_rx *alloc_mux_rx(void) { - struct mux_rx *r = NULL; + struct mux_rx *r; r = kzalloc(sizeof(*r), GFP_KERNEL); if (!r) -- 2.7.4