From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbdBVEMg (ORCPT ); Tue, 21 Feb 2017 23:12:36 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:39168 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbdBVEMa (ORCPT ); Tue, 21 Feb 2017 23:12:30 -0500 Date: Tue, 21 Feb 2017 20:11:57 -0800 From: Shaohua Li To: Minchan Kim CC: , , , , , , , , , Subject: Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Message-ID: <20170222041156.GA4077@shli-mbp.local> References: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> <20170222024721.GA17580@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170222024721.GA17580@blaptop> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [24.6.201.58] X-ClientProxiedBy: MWHPR10CA0016.namprd10.prod.outlook.com (10.172.48.26) To DM5PR15MB1644.namprd15.prod.outlook.com (10.175.106.151) X-MS-Office365-Filtering-Correlation-Id: 10497611-8997-4ba7-503b-08d45ad8f793 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1644; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1644;3:gmu8GY33NxZ0dec3FaqQQcUGZR3PkbBAGje8izSA9BiwB91ulrYSdutmzZ3MUBK++Bc5Yz6s9EsVQrOdxEfo5zYk/Tur90evZHTiWcFPxFwNH2lOB2k+Ec4QCK9qhxQQrRzBjeK0yiJkpu4yj77aq04/DUgJS81cEmonVfXtN+DALEZamtiMgODzlALRm29Be9x1xyyjIi7cyvOU9yfB/D1oZFilZ9uBGx7BZrQhdW0D2ByS0Zko3eK/jBXEJ1TLtvwax7jLb+4gCRN1R0bYxA==;25:FdGdSmJGM3vpFjXVkT74cRi3BgmpA0aiIe3VTaRuKQPr4C7KG/+biRmBr5UXZY8hTF2s4q1j4jMdskqoRvwmII1z1idcwsCs3YXp6YTuvLg1Fj0jB71Sycod0fsbUOGb0Q2Z+iMIXn10T0AHMrwrJTiaI26Kll2HxRdqZADkUGJquGMh7zDh6j1poJffJvmhDTbTDnOnnDlH3DwLQBMrX+mJHfjdHpkoq2qEyn0r4TfpKA0J83SY465RBSXmog0dhai7klBEh2DDMjoDd8w0dcuV5IM7L9YgP5k8O8VhIY9zOosR/biUGJTMVroroPd5KybbmdW+nFf+0RAVp2WZBhVqbCxk+0SRYhf4f+Kh1qtLvbQztpKwooXCd2t0yLjnhTd2n4PGx4xhr9FBxZ31isUgKVkdf1PkBiqLMbAMcr3SIDQq5WVfOKXrXpx+dzNVj44VpPEgElIcobxghUVTjA== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1644;31:SK7/eSINocc65IX6WFe9cu0d5FWechmflqxfdp960ODmba1LwqBAgtdIGw0fgl9/gEWxJWuoGTb2Kt6baiCjmLA9MKTieJ1i1GsKemDvFd4KI4sAbB8FEBAqiXP0QTR4xcVuWr/t9HBlnDulsIQO9xjPXZS6lOs+w+x5WfeviW3JDkywDaeoglh8/CKzx6x4BRydeau6s2zFtIMpJkyXBlnOwOLAVg1ZiuOKYsjc98A=;20:Qrf/Dj8zF7J1Flak+xTPM49Xt43AofzD1jmTtmf/pFk4j41e0T7Y8la480HDG2zXnTpRof9xYFusDt9zhU7nhJfY6Uh3nvOFDeZR/zNI50knkBinAFUcaEC58NOs8GmI6gUKgkJylC6UwA4SykhKOEujL3sWDO4nAM3mSP/x7keV3weARCV57H2MgVYP6YpvPtZusZTplmLa2LcV+7eYvOAqUAF5k77d1/mv2sok5B2BTEY+1RSWPyKaUnNkXv65ij/cHzFSbYxJMweMlDJEJFsp1UGyQRmHUbO38tqh/U4Owi+UbUNUiXwbmN2z0QwegE4cuK2a8AcGPCEdXrigdyC5g9Z90xmdanMKSynkW5Z5SbH5PUs6cdE6FKLiYNqLcXizaA56JR8+2Qq03FLtxLWanBJKymKEMvHiXp/c2HbW909CigPXoIA4CQzkn5jy+QQXOmwYIHiaH1qPR0tNQl13FMlApaqlDA33sgM0dfmvmz1u2acxKGVsQnvRYkpr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:DM5PR15MB1644;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1644; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1644;4:oGOCaDfMDNcjvwAF+9KThtd4OCgrqlugP3i3XODqOBDU0wDbLUlctNsoow70HauSl9wZXyrH9PcEOw0GY0bem4VbMgcArtdsopypJWl8U23MKfOvcE2S/jwdQ+gDnzaBkQnXTud91JpbYlSqPina/HwJoTlLARZrGCph0GwHyJ3TAjtwE86hWUCF7MNqsuBH3ZR0TaOOHXNJomFNj6ci+dumEhdla4iWw0EsRTwxi6LsFWTvsvuxCil4McnV5j2eifVcvlIoCNf7TaWIjj9gJcUGzO39iqpH4a6m4fvS0gDRpOpKvbxoFG/qFd7/VLnIc33qznhvdI4aQP/PdmSCuhlq61wAkkN15VMBE/oQsIX6VHgKdf4hwI+6HquoPtYYizNFS8GUvd3iYmdqPfBLNP2Pi6FfulliEPCWXD2V2xZWMMXoeMGpo4mpe4HOdSg00HAfUjmFA6iWOFH/5vbMJf3GptCzqKe5X3RH27XpqsPosvXzvZ63njOXD5OvowzqLjA2MUCtHxQHASppqvGGMXpmxZaTtB7h5vPLv93/3nz+6iO/jp1moM1nDqCNYlmGX8QdKunyRspA5GYaaAPX73wo15EjFkyoHWMW+Mwv8ERqv8VkEtF6uu+Jzkrn69oji28NGueRa+BzIYOcfxXB0lcNjpGndQwJTrmb/l68hWmja7rervk4jtBAndd5IhIS X-Forefront-PRVS: 022649CC2C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39830400002)(39450400003)(39410400002)(189002)(24454002)(199003)(2950100002)(110136004)(6116002)(53936002)(54356999)(50986999)(76176999)(68736007)(6916009)(6666003)(6246003)(38730400002)(83506001)(3846002)(101416001)(189998001)(54906002)(55016002)(229853002)(98436002)(47776003)(66066001)(305945005)(6506006)(7736002)(33656002)(5660300001)(9686003)(97756001)(50466002)(25786008)(86362001)(7416002)(81156014)(105586002)(81166006)(4001350100001)(106356001)(92566002)(42186005)(46406003)(2906002)(23726003)(4326007)(1076002)(97736004)(8676002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1644;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR15MB1644;23:vUioOklHijy0c0DH6sBwXarvMrRCwyP/1h5wD+Ck5?= =?us-ascii?Q?ChvTyn5pHNkjrVX8f3TfTC2ZHKlEA0/d+rCZQriMRmRIXpqDcH1y0I+JHOVh?= =?us-ascii?Q?fjT38tLAhN68xMvNFnuucof5glCk7F+AqPixvifsvGBFT1TYqcszswLYSqCE?= =?us-ascii?Q?pw2z8gn7+8ep1aNRukk16Nadrmlas1aJ5inXAzrHsa76GT9B1PHE0tY3K9f/?= =?us-ascii?Q?UfydQaGvp3NpH60qLn9IFM98aI5krOIrxOHwRVLElevkAsMtf9KL5SEN1+bq?= =?us-ascii?Q?Ae0V6odF+NwA72Wq2rVot4HfYve891ivWIyaIJcL7rTPwWlQ0PaLPHXzsAXN?= =?us-ascii?Q?c+oUd+ErXWouCXYH2UwZoxFJ0L1tL4a8s4CxP712sySdOcUWBVZnYfT9vJux?= =?us-ascii?Q?vuandHICsWUkK1dHqoWz5JqbSBkAYxb6adRkUMjIleTM+zpkN33lEMRPgxtZ?= =?us-ascii?Q?kk5RlL2/vHPFy/cvAbxYpohUeJOptM7ToLlREdVrs9rMBdbDOPz+2IZD7cDp?= =?us-ascii?Q?17h0E3rn4mQ2oEEqKgXAoS81TfTMwosCXiEDHxzqx1iPEbZMx2qcY+7AzGXY?= =?us-ascii?Q?FFdtlwvuxaAbw76+ZwtS8vum5e/6/RxO5/xxqKl+PeRdeua+wHiRxWpQgoaN?= =?us-ascii?Q?J+5/Cmt4PY73jhsIvVFN6MRQf8aSUubeZ9ofia7EyRrpl3zSgbWThnI50/bp?= =?us-ascii?Q?haS385YDd4VbEtQH5nnzFmwt/PqwKsjVB1t4uSCDZYv+8biuZCGBRez0TYFR?= =?us-ascii?Q?j7oAUOBth/lq1ymUlCUn8TxPiM0aLIK5O3muLleesHKP2m8C/YFmCNe5zMfL?= =?us-ascii?Q?wyKL5bXUsMjfuaZrKuNjICyZMLdfS6l6l3USlsa+nKoNaOjVnsFwYSYPrGol?= =?us-ascii?Q?ZBRJGIHsq9S9MahPR6D3UiUmtUj142H1AWB56uJL4GbxpQkn7XQbWMZHFIfW?= =?us-ascii?Q?QgKCdRXcCNAw5c1p0Z4z5sCzvIunhm1AEI0FHUdEZg54rgWVgOQV8mIMnzYH?= =?us-ascii?Q?RkxJvcrHBFZXU/V9P9/A/RGfV5Fi8/wpcv1ZICtI24oxMsJ4dKkzmTVXR2Is?= =?us-ascii?Q?gQS8gfOfidw1ExkFteKsrOCyGYsfyF7ebHzS4CDm72OycrohCu3NGK4xefVa?= =?us-ascii?Q?4f4KgTdhBlauIA0/BA3UBd9WWWxjrkquiFAJXDjeGk8/4nUKqM1G+aCAHipp?= =?us-ascii?Q?ZkNpcgy0pdNCqC28Ffe+is4NZSLiLX5Oap0pWz3QP5CY9CZgMBRwaMjFP5zv?= =?us-ascii?Q?YPk4C+mBy3EEmGlOWcqmQ4fIxUCsk5Na+TYRHNNh6TwtRcgmSLLjx+EVJlwy?= =?us-ascii?Q?s82RI1Ci6mEhsUQlvJngFww61DDWuaLtHihrVf662ZzyXHKmdjSX5CTFB8fe?= =?us-ascii?Q?t/vSQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1644;6:K/G1EtaykJKTIotJA7NfJ+cXPfPenipnpUQVYDKgLkaKtLciUJp/1pCIiWp1n4EoxEcxtnNlLyujM7aCxsufxi4rmvpHC7/NARwQdeqIbgdwHgfD+f8oGbzCohXT5wtHepAGU192h9lmcYD5X2LYMJyoNs9mBWLKiswFcGtBzO3Nc8+xF7jRMsZlYK+uSoA8Sk98InV6u5vCw5KLq29zpvlXdJb48I/2c24of7/wNaA0bfsChTerfTNNKK2Krxcg1pq8zW05nm/q4yCFu6Cyw4NVk3Lw4MA5EL6rvtFppXEPKPMr/3Zj0ZcfPt0c5XYWU9+S6FNHeA4lWW46AXSPv5AtlMkcKqsLn2W/hTr3TqLN/wDx9TFUF3QmX6SZjkWBQndaW9k69QZIgy02KlZ1zw==;5:itWRCyFmqV2YZgbIMu5UDGIkFKLRWxiBa81aABsdny1sh0SodqflezgJCkS4+fcXgcTai1EPVeiOasHGStfQrdORCopf4Guf311CSKXwNpLTMPW+iuJrFsw9asE8JTt816t7fLWerX+A6ZUrldkXDg==;24:RU0oR2JprH8eIt7oBz4hYdxu0klVhU5/hXcXJoM12HcqsoZdqnwkM/gdka/GL790DSb4hgrgpD4a8/KPI4iiFr9PfVABuObTVGORdSnwCCM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1644;7:oh1J8sS5zPLsVHMsOmmebTqfhq7KbqymEoznvXBbNbtqdiy9ipy7Rv9wmYSBVUA/9n+vjYInBHtI5b+nKtE++y5hQCA7IJtcf1m+wQTD3aqeiZFQVjRM9+PJz7hj+LY/Hh7FKs81kAUTRBi9w3SS3js+UWC1gRqpN3z0jREIiblXVf34z5lDArqh9guP862f/CfIoisP9J2YguLW13KTX3XulVZn/SGaPe3U2MQ9TJ9BqULQpnh9MXbY/ARHRLTkXxSZhgfaag79M1ITPf+562ezGTiKMj9hdVf2gLErzNK7n+O+zYrzwCWE8mvKiaS23xG9oDmvzRD3FeCG0ljalw==;20:Pfas+5giqCCfqcFvdFiiBsQvPvo4wAuuvvoZybysxf2cH2iRMXdr3qiyzjYa1iAkGCRY4Q0nc8BcNgMzUP4CFS1zq8FJ8mXfljsCiHS/FQGYIWdiUoLcvqzD2QM0xNfyAITyfKP23DPe9XvXiX8JbQiY1X0n9tpKAc2IyDaSQao= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 04:12:06.9026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1644 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-22_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 11:47:21AM +0900, Minchan Kim wrote: > On Fri, Feb 03, 2017 at 03:33:22PM -0800, Shaohua Li wrote: > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Johannes Weiner > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Signed-off-by: Shaohua Li > > --- > > fs/proc/task_mmu.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index ee3efb2..8f2423f 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -440,6 +440,7 @@ struct mem_size_stats { > > unsigned long private_dirty; > > unsigned long referenced; > > unsigned long anonymous; > > + unsigned long lazyfree; > > unsigned long anonymous_thp; > > unsigned long shmem_thp; > > unsigned long swap; > > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > > int i, nr = compound ? 1 << compound_order(page) : 1; > > unsigned long size = nr * PAGE_SIZE; > > > > - if (PageAnon(page)) > > + if (PageAnon(page)) { > > mss->anonymous += size; > > + if (!PageSwapBacked(page)) > > How about this? > > if (!PageSwapBacked(page) && !dirty && !PageDirty(page)) Yes, already fixed like this. Thanks, Shaohua