From: Oleg Nesterov <oleg@redhat.com>
To: bsegall@google.com
Cc: linux-kernel@vger.kernel.org, Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state
Date: Wed, 22 Feb 2017 18:03:25 +0100 [thread overview]
Message-ID: <20170222170325.GB15968@redhat.com> (raw)
In-Reply-To: <20170222165538.GA15968@redhat.com>
On 02/22, Oleg Nesterov wrote:
>
> note also that PTRACE_LISTEN itself can do ptrace_signal_wake_up(true),
please ignore, in this case the __TASK_TRACED at the start of _unfreeze()
saves us.
>
> > This causes it to instead clobber TASK_WAKING,
>
> even if it is already TASK_RUNNING it is simply wrong to set TASK_TRACED
> in both cases, right?
>
> Thanks. The patch looks good at first glance, but let me think a bit...
> perhaps we should change PTRACE_LISTEN instead, not sure.
>
> Oleg.
next prev parent reply other threads:[~2017-02-22 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 18:47 bsegall
2017-02-22 16:55 ` Oleg Nesterov
2017-02-22 17:03 ` Oleg Nesterov [this message]
2017-02-22 17:56 ` bsegall
2017-02-24 16:36 ` Oleg Nesterov
2017-02-27 18:08 ` bsegall
2017-04-04 21:47 ` [PATCHv2] " bsegall
2017-04-04 21:53 ` Andrew Morton
2017-04-05 12:36 ` Oleg Nesterov
2017-04-05 12:30 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222170325.GB15968@redhat.com \
--to=oleg@redhat.com \
--cc=bsegall@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome