From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934564AbdBVUua (ORCPT ); Wed, 22 Feb 2017 15:50:30 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:36062 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934543AbdBVUuU (ORCPT ); Wed, 22 Feb 2017 15:50:20 -0500 Date: Wed, 22 Feb 2017 14:50:17 -0600 From: Rob Herring To: Greentime Hu Cc: arnd@arndb.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: net: generalize moxart-mac to support all faraday based ftmac IP Message-ID: <20170222205017.7ssyl2cdlclpytnp@rob-hp-laptop> References: <20170214085621.GA11829@app09> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214085621.GA11829@app09> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 04:56:30PM +0800, Greentime Hu wrote: > Andestech and moxa use the same faraday mac IP, so we use faraday,ftmac.txt to describe it. Please wrap your lines. > Signed-off-by: Greentime Hu > --- > .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} | 7 +++++-- > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 6 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%) > > diff --git a/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt b/Documentation/devicetree/bindings/net/faraday,ftmac.txt > similarity index 68% > rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt > rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt > index 583418b..be4f55e 100644 > --- a/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt > +++ b/Documentation/devicetree/bindings/net/faraday,ftmac.txt > @@ -1,8 +1,11 @@ > -MOXA ART Ethernet Controller > +Faraday Ethernet Controller > > Required properties: > > -- compatible : Must be "moxa,moxart-mac" > +- compatible : Must contain "faraday,ftmac", as well as one of > + the SoC specific identifiers: > + "andestech,atmac100" > + "moxa,moxart-mac" > - reg : Should contain register location and length > - interrupts : Should contain the mac interrupt number > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 16d3b5e..489c336 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -102,6 +102,7 @@ everest Everest Semiconductor Co. Ltd. > everspin Everspin Technologies, Inc. > excito Excito > ezchip EZchip Semiconductor > +faraday Faraday Technology Corporation As Linus mentioned, I did apply the same thing already, so drop this hunk. > fcs Fairchild Semiconductor > firefly Firefly > focaltech FocalTech Systems Co.,Ltd > -- > 1.7.9.5 >