mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mike Galbraith <efault@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] scheduler changes for v4.11
Date: Wed, 22 Feb 2017 20:51:44 +0000	[thread overview]
Message-ID: <20170222205144.GV28416@codeblueprint.co.uk> (raw)
In-Reply-To: <CA+55aFxtTX7_ob=Ca4iWD-NDQVESRC8m8tWq=HsbUb_akHF79A@mail.gmail.com>

On Wed, 22 Feb, at 12:41:01PM, Linus Torvalds wrote:
> Hmm. The scheduler changes seem to show problems with suspend/resume.
> 
> I now get his when suspending:
> 
>   ...
>   Disabling non-boot CPUs ...
>   Cannot set affinity for irq 285
>   smpboot: CPU 1 is now offline
>   ------------[ cut here ]------------
>    WARNING: CPU: 2 PID: 25 at kernel/sched/sched.h:812
> update_load_avg+0x779/0xa70
>   rq->clock_update_flags < RQCF_ACT_SKIP
>   ...
>   Call Trace:
>     update_load_avg+0x779/0xa70
>     set_next_entity+0xd9/0x220
>     pick_next_task_fair+0x88/0x550
>     sched_cpu_dying+0x1cf/0x2a0
>     cpuhp_invoke_callback+0x80/0x3b0
>     take_cpu_down+0x5e/0xa0
>     multi_cpu_stop+0xb6/0xe0
> 
> the issue may have been going on for a while, but the new WARN_ON()
> was added in this merge window.
> 
> (Not sure how consistent this warning is, it definitely doesn't happen
> every time, I've only seen it once)

I think Peter has the fix for this somewhere, but it doesn't look like
it made it to tip/sched/core.

Peter, this is the original patch,

  https://lkml.kernel.org/r/20170202155506.GX6515@twins.programming.kicks-ass.net

  reply	other threads:[~2017-02-22 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 10:17 Ingo Molnar
2017-02-22 20:41 ` Linus Torvalds
2017-02-22 20:51   ` Matt Fleming [this message]
2017-02-22 21:11     ` Peter Zijlstra
2017-02-24  7:53       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222205144.GV28416@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome