From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbdBWEC3 (ORCPT ); Wed, 22 Feb 2017 23:02:29 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32779 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbdBWECZ (ORCPT ); Wed, 22 Feb 2017 23:02:25 -0500 Date: Thu, 23 Feb 2017 05:01:43 +0100 From: Frederic Weisbecker To: Michael Ellerman Cc: LKML , Abdul Haleem , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error Message-ID: <20170223040142.GA5323@lerouge> References: <1487690321-21553-1-git-send-email-fweisbec@gmail.com> <87fuj5zz8o.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fuj5zz8o.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2017 at 08:34:15AM +1100, Michael Ellerman wrote: > Frederic Weisbecker writes: > > > This type conversion is a leftover that got ignored during the kcpustat > > conversion to nanosecs, resulting in build breakage with config having > > CONFIG_NO_HZ_FULL=y. > > > > arch/powerpc/kernel/time.c: In function 'running_clock': > > arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration] > > return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]); > > > > All we need is to remove it. > > > > Reported-by: Abdul Haleem > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: Oliver O'Halloran > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Frederic Weisbecker > > LGTM. > > Acked-by: Michael Ellerman > > > Are you going to send this to Linus, or should I? I would prefer you send it to Linus if you don't mind. The fate of a powerpc patch sent by me directly to Linus is anything but predictable :o) Thanks.