From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbdBWIni (ORCPT ); Thu, 23 Feb 2017 03:43:38 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37528 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbdBWInI (ORCPT ); Thu, 23 Feb 2017 03:43:08 -0500 Date: Thu, 23 Feb 2017 09:42:41 +0100 From: Alexandre Belloni To: Claudiu Beznea Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, ludovic.desroches@atmel.com, cyrille.pitchen@atmel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Message-ID: <20170223084241.6eqm5jxe4t7fpn6a@piout.net> References: <1487838778-13473-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487838778-13473-1-git-send-email-claudiu.beznea@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, There is a typo in your subject, please fix. On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: > Add pwm controller bindings for sam5d2_xplained > and enable it. > > Signed-off-by: Claudiu Beznea > --- > arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++ > arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > index 9fc270f..493ea29 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > @@ -318,6 +318,10 @@ > }; > }; > > + pwm0: pwm@f802c000 { > + status = "okay"; > + }; > + > flx0: flexcom@f8034000 { > atmel,flexcom-mode = ; > status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */ > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > index cd459e8..e88785e 100644 > --- a/arch/arm/boot/dts/sama5d2.dtsi > +++ b/arch/arm/boot/dts/sama5d2.dtsi > @@ -1098,6 +1098,14 @@ > status = "disabled"; > }; > > + pwm0: pwm@f802c000 { > + compatible = "atmel,sama5d2-pwm"; This compatible is not documented and is not used in any driver. Is that really working? > + reg = <0xf802c000 0x4000>; > + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>; > + #pwm-cells = <3>; > + clocks = <&pwm_clk>; > + }; > + > sfr: sfr@f8030000 { > compatible = "atmel,sama5d2-sfr", "syscon"; > reg = <0xf8030000 0x98>; > -- > 2.7.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com