From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbdBWVrP (ORCPT ); Thu, 23 Feb 2017 16:47:15 -0500 Received: from mail1.windriver.com ([147.11.146.13]:55891 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbdBWVrN (ORCPT ); Thu, 23 Feb 2017 16:47:13 -0500 From: Paul Gortmaker To: CC: Paul Gortmaker , Jaehoon Chung , Jingoo Han , Kishon Vijay Abraham I , Kukjin Kim , Krzysztof Kozlowski , Pankaj Dubey , Vivek Gautam , Javier Martinez Canillas , Bjorn Helgaas , , Subject: [PATCH] phy: phy-exynos-pcie: make it explicitly non-modular Date: Thu, 23 Feb 2017 16:46:03 -0500 Message-ID: <20170223214603.18692-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Kconfig currently controlling compilation of this code is: drivers/phy/Kconfig:config PHY_EXYNOS_PCIE drivers/phy/Kconfig: bool "Exynos PCIe PHY driver" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Jaehoon Chung Cc: Jingoo Han Cc: Kishon Vijay Abraham I Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Pankaj Dubey Cc: Vivek Gautam Cc: Javier Martinez Canillas Cc: Bjorn Helgaas Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Paul Gortmaker --- [ I'd normally not send patches in the merge window, but this driver just appeared in linux-next and so I'm assuming it is intended for addition during this merge window, hence we might as well fix it now.] drivers/phy/phy-exynos-pcie.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c index 4f60b83641d5..d92d8616a106 100644 --- a/drivers/phy/phy-exynos-pcie.c +++ b/drivers/phy/phy-exynos-pcie.c @@ -14,8 +14,8 @@ #include #include #include +#include #include -#include #include #include #include @@ -228,7 +228,6 @@ static const struct of_device_id exynos_pcie_phy_match[] = { }, {}, }; -MODULE_DEVICE_TABLE(of, exynos_pcie_phy_match); static int exynos_pcie_phy_probe(struct platform_device *pdev) { @@ -278,8 +277,4 @@ static struct platform_driver exynos_pcie_phy_driver = { .name = "exynos_pcie_phy", } }; -module_platform_driver(exynos_pcie_phy_driver); - -MODULE_DESCRIPTION("Samsung S5P/EXYNOS SoC PCIe PHY driver"); -MODULE_AUTHOR("Jaehoon Chung "); -MODULE_LICENSE("GPL v2"); +builtin_platform_driver(exynos_pcie_phy_driver); -- 2.11.0