From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdBXQMC (ORCPT ); Fri, 24 Feb 2017 11:12:02 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36824 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbdBXQLy (ORCPT ); Fri, 24 Feb 2017 11:11:54 -0500 Date: Fri, 24 Feb 2017 11:11:52 -0500 (EST) Message-Id: <20170224.111152.713364995055339756.davem@davemloft.net> To: fengguang.wu@intel.com Cc: santosh.shilimkar@oracle.com, kbuild-all@01.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Subject: Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings From: David Miller In-Reply-To: <20170223124700.GA9908@lkp-hsx03.lkp.intel.com> References: <201702232002.caFuWJ4l%fengguang.wu@intel.com> <20170223124700.GA9908@lkp-hsx03.lkp.intel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Feb 2017 07:13:00 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot Date: Thu, 23 Feb 2017 20:47:01 +0800 > net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > Signed-off-by: Fengguang Wu Applied.