From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbdBXTaR (ORCPT ); Fri, 24 Feb 2017 14:30:17 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39728 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdBXT35 (ORCPT ); Fri, 24 Feb 2017 14:29:57 -0500 Date: Fri, 24 Feb 2017 14:29:32 -0500 (EST) Message-Id: <20170224.142932.902090866869403269.davem@davemloft.net> To: geert@linux-m68k.org Cc: isubramanian@apm.com, kchudgar@apm.com, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: net: xgene: Simplify xgene_enet_setup_mss() to kill warning From: David Miller In-Reply-To: <1487932203-31799-1-git-send-email-geert@linux-m68k.org> References: <1487932203-31799-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Feb 2017 10:30:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v1OJUNHs024897 From: Geert Uytterhoeven Date: Fri, 24 Feb 2017 11:30:03 +0100 > With gcc-4.1.2 and -Os: > > drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function Ħxgene_enet_start_xmit˘: > drivers/net/ethernet/apm/xgene/xgene_enet_main.c:297: warning: Ħmss_index˘ may be used uninitialized in this function > > Using a separate variable to track success may confuse the compiler. > Preinitialize mss_index with -EBUSY and check for negative error values > instead to kill the warning. > > Signed-off-by: Geert Uytterhoeven Applied, thank you.