From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbdBXHpe (ORCPT ); Fri, 24 Feb 2017 02:45:34 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50705 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750942AbdBXHpV (ORCPT ); Fri, 24 Feb 2017 02:45:21 -0500 From: Ravi Bangoria To: mingo@redhat.com, acme@kernel.org, masami.hiramatsu.pt@hitachi.com Cc: brendan.d.gregg@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com, mathieu.poirier@linaro.org, hekuang@huawei.com, sukadev@linux.vnet.ibm.com, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com, Ravi Bangoria Subject: [PATCH v3 1/2] perf/sdt: Introduce util func is_sdt_event() Date: Fri, 24 Feb 2017 13:13:24 +0530 X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170224074325.2451-1-ravi.bangoria@linux.vnet.ibm.com> References: <20170224074325.2451-1-ravi.bangoria@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022407-0048-0000-0000-000002098423 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022407-0049-0000-0000-00004798062B Message-Id: <20170224074325.2451-2-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-24_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702240079 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No Functionality changes. Signed-off-by: Ravi Bangoria --- tools/perf/util/probe-event.c | 9 +-------- tools/perf/util/util.c | 12 ++++++++++++ tools/perf/util/util.h | 2 ++ 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 28fb62c..2b1409f 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -1339,14 +1339,7 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev) if (!arg) return -EINVAL; - /* - * If the probe point starts with '%', - * or starts with "sdt_" and has a ':' but no '=', - * then it should be a SDT/cached probe point. - */ - if (arg[0] == '%' || - (!strncmp(arg, "sdt_", 4) && - !!strchr(arg, ':') && !strchr(arg, '='))) { + if (is_sdt_event(arg)) { pev->sdt = true; if (arg[0] == '%') arg++; diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index d8b45ce..b827428 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -802,3 +802,15 @@ int unit_number__scnprintf(char *buf, size_t size, u64 n) return scnprintf(buf, size, "%" PRIu64 "%c", n, unit[i]); } + +/* + * If the probe point starts with '%', + * or starts with "sdt_" and has a ':' but no '=', + * then it should be a SDT/cached probe point. + */ +bool is_sdt_event(char *str) +{ + return (str[0] == '%' || + (!strncmp(str, "sdt_", 4) && + !!strchr(str, ':') && !strchr(str, '='))); +} diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h index c74708d..ee599dc 100644 --- a/tools/perf/util/util.h +++ b/tools/perf/util/util.h @@ -364,4 +364,6 @@ int is_printable_array(char *p, unsigned int len); int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz); int unit_number__scnprintf(char *buf, size_t size, u64 n); + +bool is_sdt_event(char *str); #endif /* GIT_COMPAT_UTIL_H */ -- 2.9.3