From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbdBXLAK (ORCPT ); Fri, 24 Feb 2017 06:00:10 -0500 Received: from smtp-68.nebula.fi ([83.145.220.68]:49033 "EHLO smtp.nebula.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751129AbdBXLAE (ORCPT ); Fri, 24 Feb 2017 06:00:04 -0500 X-Greylist: delayed 306 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Feb 2017 06:00:03 EST Date: Fri, 24 Feb 2017 12:54:23 +0200 From: Stefan Kristiansson To: Jonas Bonn Cc: Stafford Horne , linux@roeck-us.net, openrisc@lists.librecores.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/24] openrisc: head: refactor out tlb flush into it's own function Message-ID: <20170224105422.GA21431@chokladfabriken.org> References: <8c9b7db0de3d64c9a6fcd12622636d4aa6a8c30c.1487910170.git.shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org eOn Fri, Feb 24, 2017 at 10:57:19AM +0100, Jonas Bonn wrote: > On 02/24/2017 05:32 AM, Stafford Horne wrote: > >From: Stefan Kristiansson > > > >This brings it inline with the other setup oprations done like the cache > >enables _ic_enable and _dc_enable. Also, this is going to make it > >easier to initialize additional cpu's when smp is introduced. > > This patch confuses me. The TLB flush is moved to a point after MMU's are > enabled. The TLB flush should happen before enabling the MMU, shouldn't it? > It still happens before the MMUs are enabled, the patch only refactors the code out into a function that is called from the place where it was open coded before. Stefan