mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 05/19] hwmon: (adt7475) Add OF device ID table
Date: Fri, 24 Feb 2017 10:12:58 -0300	[thread overview]
Message-ID: <20170224131313.953-6-javier@osg.samsung.com> (raw)
In-Reply-To: <20170224131313.953-1-javier@osg.samsung.com>

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/hwmon/adt7475.c | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index c646670b9ea9..fcfa48222145 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -13,6 +13,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/of_device.h>
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/i2c.h>
@@ -161,6 +162,27 @@ static const struct i2c_device_id adt7475_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, adt7475_id);
 
+static const struct of_device_id adt7475_of_match[] = {
+	{
+		.compatible = "adi,adt7473",
+		.data = (void *)adt7473
+	},
+	{
+		.compatible = "adi,adt7475",
+		.data = (void *)adt7475
+	},
+	{
+		.compatible = "adi,adt7476",
+		.data = (void *)adt7476
+	},
+	{
+		.compatible = "adi,adt7490",
+		.data = (void *)adt7490
+	},
+	{ },
+};
+MODULE_DEVICE_TABLE(of, adt7475_of_match);
+
 struct adt7475_data {
 	struct device *hwmon_dev;
 	struct mutex lock;
@@ -1250,6 +1272,7 @@ static void adt7475_remove_files(struct i2c_client *client,
 static int adt7475_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
+	enum chips chip;
 	static const char * const names[] = {
 		[adt7473] = "ADT7473",
 		[adt7475] = "ADT7475",
@@ -1268,8 +1291,13 @@ static int adt7475_probe(struct i2c_client *client,
 	mutex_init(&data->lock);
 	i2c_set_clientdata(client, data);
 
+	if (client->dev.of_node)
+		chip = (enum chips)of_device_get_match_data(&client->dev);
+	else
+		chip = id->driver_data;
+
 	/* Initialize device-specific values */
-	switch (id->driver_data) {
+	switch (chip) {
 	case adt7476:
 		data->has_voltage = 0x0e;	/* in1 to in3 */
 		revision = adt7475_read(REG_DEVID2) & 0x07;
@@ -1428,6 +1456,7 @@ static struct i2c_driver adt7475_driver = {
 	.class		= I2C_CLASS_HWMON,
 	.driver = {
 		.name	= "adt7475",
+		.of_match_table = of_match_ptr(adt7475_of_match),
 	},
 	.probe		= adt7475_probe,
 	.remove		= adt7475_remove,
-- 
2.9.3

  parent reply	other threads:[~2017-02-24 13:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 13:12 [PATCH 00/19] hwmon: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-02-24 13:12 ` [PATCH 01/19] hwmon: (ad7414) Add OF device ID table Javier Martinez Canillas
2017-02-24 13:12 ` [PATCH 02/19] hwmon: (adc128d818) " Javier Martinez Canillas
2017-02-24 13:12 ` [PATCH 03/19] hwmon: (ads1015) " Javier Martinez Canillas
2017-02-24 13:12 ` [PATCH 04/19] hwmon: (ads7828) " Javier Martinez Canillas
2017-02-24 13:12 ` Javier Martinez Canillas [this message]
2017-02-24 13:12 ` [PATCH 06/19] hwmon: (ina209) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 07/19] hwmon: (ina2xx) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 08/19] hwmon: (lm63) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 09/19] hwmon: (lm75) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 10/19] hwmon: (lm85) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 11/19] hwmon: (lm90) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 12/19] hwmon: (lm95245) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 13/19] hwmon: (max6697) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 14/19] hwmon: (ucd9000) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 15/19] hwmon: (ucd9200) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 16/19] hwmon: (stts751) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 17/19] hwmon: (tmp102) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 18/19] hwmon: (tmp103) " Javier Martinez Canillas
2017-02-24 13:13 ` [PATCH 19/19] hwmon: (tmp421) " Javier Martinez Canillas
2017-02-24 17:10 ` [PATCH 00/19] hwmon: Add OF device table to I2C drivers that are missing it Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224131313.953-6-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®