mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>,
	chao@kernel.org, sylinux@163.com, miaoxie@huawei.com,
	bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment
Date: Fri, 24 Feb 2017 09:58:21 -0800	[thread overview]
Message-ID: <20170224175821.GB39009@jaegeuk.local> (raw)
In-Reply-To: <58B01BCF.1050207@huawei.com>

On 02/24, Yunlong Song wrote:
> Hi, Chao,
> 
> Not looks good to me, since there is some case your code does not include:
> if type is CURSEG_HOT_DATA, and if get_victim also returns 0 for both CURSEG_HOT_DATA and
> CURSEG_WARM_DATA, then i will be -1 and pass to get_victim in your code.  So I still suggest
> my original patch attached below.

Why does i become -1?

> 
> On 2017/2/24 18:47, Chao Yu wrote:
> > On 2017/2/24 17:19, Yunlong Song wrote:
> >> Hi Jaegeuk and Chao,
> >>
> >>     How about the question I pointed out in last mail:
> >>     Why not take "neighboring temperature" for ssr? For example, if type == CURSEG_COLD_DATA,
> >>     the new patch selects CURSEG_HOT_DATA first, why not select CURSEG_WARM_DATA first?
> >>     The patch I sent ensure this "neighboring temperature" for ssr. This is to reduce the influence of
> >>     mixing different levels of hot/code node types.
> > Agreed, I sent one patch for changing the policy of SSR, how do you think of it?
> >
> > Thanks,
> >
> >> On 2017/2/24 17:05, Chao Yu wrote:
> >>> Hi Jaegeuk,
> >>>
> >>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> >>>
> >>> For your attached two patches.
> >>>
> >>> Thanks,
> >>>
> >>> On 2017/2/23 9:17, Jaegeuk Kim wrote:
> >>>> Hi Yunlong,
> >>>>
> >>>> I've been testing the similar patches as I attached.
> >>>>
> >>>> Thanks,
> >>>>
> >>>> On 02/22, Yunlong Song wrote:
> >>>>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> >>>>> ---
> >>>>>  fs/f2fs/segment.c | 9 +++++++++
> >>>>>  1 file changed, 9 insertions(+)
> >>>>>
> >>>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> >>>>> index 9d13743..5fe71b9 100644
> >>>>> --- a/fs/f2fs/segment.c
> >>>>> +++ b/fs/f2fs/segment.c
> >>>>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
> >>>>>  {
> >>>>>  	struct curseg_info *curseg = CURSEG_I(sbi, type);
> >>>>>  	const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
> >>>>> +	int old_type = type;
> >>>>>  
> >>>>>  	if (IS_NODESEG(type)) {
> >>>>>  		for (; type >= CURSEG_HOT_NODE; type--)
> >>>>>  			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
> >>>>>  							BG_GC, type, SSR))
> >>>>>  				return 1;
> >>>>> +		for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++)
> >>>>> +			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
> >>>>> +							BG_GC, type, SSR))
> >>>>> +				return 1;
> >>>>>  		return 0;
> >>>>>  	}
> >>>>>  
> >>>>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
> >>>>>  		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
> >>>>>  						BG_GC, type, SSR))
> >>>>>  			return 1;
> >>>>> +	for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++)
> >>>>> +		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
> >>>>> +						BG_GC, type, SSR))
> >>>>> +			return 1;
> >>>>>  	return 0;
> >>>>>  }
> >>>>>  
> >>>>> -- 
> >>>>> 1.8.5.2
> >>> .
> >>>
> >>
> >
> > .
> >
> 
> 
> -- 
> Thanks,
> Yunlong Song
> 

  reply	other threads:[~2017-02-24 17:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 12:50 [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song
2017-02-22 12:50 ` [PATCH 2/3] f2fs: provide more chance to get node ssr Yunlong Song
2017-02-22 12:50 ` [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song
2017-02-23  1:17   ` Jaegeuk Kim
2017-02-23  2:13     ` Yunlong Song
2017-02-23  2:41       ` Yunlong Song
2017-02-24  9:05     ` Chao Yu
2017-02-24  9:19       ` Yunlong Song
2017-02-24 10:47         ` Chao Yu
2017-02-24 11:41           ` Yunlong Song
2017-02-24 17:58             ` Jaegeuk Kim [this message]
     [not found]               ` <b5c6b4d.d7.15a7177d92d.Coremail.sylinux@163.com>
2017-02-24 20:05                 ` Jaegeuk Kim
2017-02-25  2:16                   ` Yunlong Song
2017-02-23  0:41 ` [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim
2017-02-23  0:59   ` Jaegeuk Kim
2017-02-23  1:55     ` Yunlong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224175821.GB39009@jaegeuk.local \
    --to=jaegeuk@kernel.org \
    --cc=bintian.wang@huawei.com \
    --cc=chao@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=sylinux@163.com \
    --cc=yuchao0@huawei.com \
    --cc=yunlong.song@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®