From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbdBXVs0 (ORCPT ); Fri, 24 Feb 2017 16:48:26 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:60783 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdBXVsY (ORCPT ); Fri, 24 Feb 2017 16:48:24 -0500 Date: Fri, 24 Feb 2017 13:47:25 -0800 From: Shaohua Li To: Dave Hansen CC: , , , , , , , , , Subject: Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps Message-ID: <20170224214724.GA35601@shli-mbp.local> References: <7f22d33b2f388ce33448faa75be75f9a52d57052.1487788131.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::a:629] X-ClientProxiedBy: MWHPR14CA0033.namprd14.prod.outlook.com (10.171.142.147) To MWHPR15MB1648.namprd15.prod.outlook.com (10.175.139.151) X-MS-Office365-Filtering-Correlation-Id: c20ba7c5-3a99-46e8-c231-08d45cfebde7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1648; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;3:ZWeq7BuIuCghjIJq3GQguCPNHHDANvvBTSlS6MSiOSmRYVTQ3JqcQ6sQsPg7vs2HTlRHPbJVmyAS5Lp68tbJ3Hln5crU93CiqDjTlK6cpX5UpJytS9Ppwe/Fbr+OhUUtgLWD1BzsDUko44SnZw7PRH2xzIJVMaEHwB3h2z5FinfPNky8gsO7xNU9O2ST25SBidDxlQMBRnmSuX/jzWZMgjjRhEOo+JKRMt/MhX8D9J8aIXJpnHGyc+tBzzCzzBbGOYaSqYJRUWqR1O54NsKmDQ==;25:nyM7tr8nYYcHKnmE7K+7XvyZSpM/MRv4s7gqyGq/PCQrQV9fB9RPfqUEcyt5cFAh9dXpxe5WUicI5Guh6P0zYBBqRNnYC5ENTQ3XbaErmsJyK90NdKY0OkysGNomWXh2ix1NzcvrtQ5722bJmthtV8XIWI00IKFwWyo4PTSAOBZJa/7GNHpMLoc3PBsppIqeStUWwFPDqa/ZwUtOugY/5nQRC6cqytCYT7XqrsHNLjCcyr6gjcCZeo/1dK4/Fz5A9h5Vr3fcD2zwvE0mfxhIRmx9bJF3k+loFTfuoVtUvSbIQfUjguykRI8kt2TkZD3bH4iRDk7DGBkwscxRa/nCDywXhJOfZ2VsYg9Huv2wsgCPfHX/WMC3EGm5OkkffXdkZN5UOsoibQX7e/giqr1vA7gr2ByyUjG/O5UICx+uGsdTBgb7jjJtlRhkoFFn+P3GpdGWmYa9QFHajbCLqtEVXQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;31:RZ6ByMu9OfvE4rebyH5veMfQ8PkxQmmhg5Xg9qEhk1U43ymu7QllI1dWOZeMtxHwgNCpV6c8y9RxeGMG8AmoPqxD1G8J9XGVmUUgnpcmwtL2jAnncF0LTnQMuLAHMCItT29PAcqSbMN67WeWsTXoRMRST2LBOl8bA+EOA74gOmIvb3YoZceq6VpP4Ll1YN1OsIlSso+8cMN4MuFyFayKrMJCAXvycTZPxuo6BBGL2v/HGuMlj+W4FElrHpazHmQT;20:1seje9ej6puGAsEk9CmW7W5lyqOYsFohiaJ2XHm35nav2ggg0oAipcsTCnUPDTze/8tLsZJZr7M83wFbComYK3glw5lLtfSVokOWC5U5fEYmysgj4HFCL6dZufWRwNMmvefpWcCLqJ/bzfsFEImJuiKbTdBHRU4Z5s3Y3euTat9Z36/EKn02ahVfaP8znrqdnRlTpPgM8xQVLyELQefz+AMF/SyjTAJo5y/p/fEbTQHvv9N9TYxiyQ47LilQywzze0Y/FG3Ul8M6ctWi1kAhEZZLqmRFkfni/gTYfUfLVjhyKINWUGsQQoUgFNiQQHz3WOkXIBoDMBsFUuBmKHLq+GKAh581b7YvjwvwWZO8P7DAarLNrn5Vj7pHhB1boHvo5cHraETMthcdiBJbTJg7LQor+Et8gR/bwwGs2e1/Kfw45qFEzhlxDFfx2ZdeYYMYLptl4Q5gf58vZrPXxY3msiZjKO/2qWqVDWbx2Frqg3F+G3/17IEL36w1FsKbMuQZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148);SRVR:MWHPR15MB1648;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1648; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;4:kwUAar+8/EKfCyUowEcz6XiaJNbQ+TaD7xL80+DQpiLqWMuTmsXDVZ5DWArA3RzerfJjeTvPCVMQgMPu1iBAfHYvNcDRjpjo4jMbm9mKbUR8zLEyW2YT5phq03T9aSyLi0KfoT9CdipXAbPVTtm8TpCxWPfB+6+xClW7XPNt44GUIpWYpGBHLLCyvh732Dt1qsooRUx4RCt2w7DFd29V8rD8LWWPQ4z15e6CYDJra+MaS+VIpxGiFjzly8ktQFzWEJrb0+p1VEjCGxEgITRSwgCrbfbPh98gBEKJeimnyv6jSBytvwaFKMws82onBqtnn6wfMCjfUjoMt7GP4AgpYSIGmDWfYFrJiJK7tVvgXV9W9jfljgclUssXUwBX3qaGJY/+vPmwAC2tAaEYbQPusH0d/epkVpIJIOMN2C5M7cjpMEs107mYk8+OFmxE5t/UjjTBRZsFpj3AOPpX5LIE6qVQtp2blYquzJFUgyARdWUY+fDpSTEbElrmyOAtYJFT7PAr/imC/ANaSFgXpor7OGs45M2yu7GgIM4XDMbmjouoIK6ABrd2cx4lreh6RC3+7fh8I7uXyH/Ryd0Zfk60QBgVAui5PPJn7TafoXA42Kg= X-Forefront-PRVS: 0228DDDDD7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(39830400002)(39410400002)(199003)(189002)(377454003)(24454002)(97756001)(47776003)(229853002)(6666003)(6506006)(92566002)(105586002)(106356001)(42186005)(5660300001)(101416001)(54356999)(50986999)(6916009)(50466002)(2950100002)(6116002)(81166006)(81156014)(83506001)(7416002)(76176999)(68736007)(2906002)(33656002)(98436002)(305945005)(46406003)(23726003)(1076002)(4326007)(6246003)(7736002)(53546006)(8676002)(38730400002)(110136004)(97736004)(55016002)(53936002)(54906002)(9686003)(4001350100001)(189998001)(25786008)(86362001)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1648;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR15MB1648;23:3xR1KH6lFvhhrbCNqzwzT+iCkcQUJDwgm/1Mb0Ggt?= =?us-ascii?Q?tX+lRP+O9UplWQ/GTT+mCulFUV8pkkGUF53jrHMb3w3tMS3XftxyPVmWlETS?= =?us-ascii?Q?+MIDqJ/CAt4ucO9voU0W/7uS3SYfDm47J5BSB+/zTr9Y6pBXD1KzBMmDFKe6?= =?us-ascii?Q?mZJHgetkfMI0y22ByeDZx10MPMlrUmohAhVvG0ga/cU5/C30iLKu5LDD72WS?= =?us-ascii?Q?hckg7y+Eve6rKsmwR/f268DK2xVn1ZAzTFulN3wqhDSZj0MVTft59T8rjFm8?= =?us-ascii?Q?501rjTRCyJgP94g6g3Eex5FYUgZp4HlkGsRhGgtjZnZUMX7L5JfiljkuCsi0?= =?us-ascii?Q?Wv1yvZ7iEIl4dQU0igY36y+vszMJBytXCgi03kzTFJgoA8X6qUZDBmgsAYjO?= =?us-ascii?Q?au4xpgeKB9FW23wKuACCh8U9e6VmVb5QEa4LiLoZ1MI31NjBUSa+txa5YleE?= =?us-ascii?Q?EPC1NjI7zy+6Dszi5QvItywAHuznHSxUfyGlON9a1YOQTqCZVGUdxYX1fvF1?= =?us-ascii?Q?/oA0ZWOhAicNLEgTRcRfyvqjqWWr+XQMFxtuePXAb1+DfhtKCX5suXNjtg9h?= =?us-ascii?Q?HY4Yfzp8ZYC5AmfrOBzJcJvqPLTCnG/z0SIBwgH0lRbRe/zaOpj31Anaf9OC?= =?us-ascii?Q?Zuxj3lBTonplHHsQMUzrgdPKMC4i7PxQE1+gCrqA8eDvOJSEYcAhBuhp5up1?= =?us-ascii?Q?ys4oeK0UhWfyxHAobe9HqCZtCdvycX2w4SE3e40+mB24WRGnVol3HxFOyBNe?= =?us-ascii?Q?vRfkXdg29RH+Rpl68oMPc11JKxGyjk/ijIrFYoYOr5xU8gciTH8UdgfOMOV2?= =?us-ascii?Q?KELmdYc4rNFLvbJfAYSUpc59nw5eYic/HIkJLwMaEAut7zeFyGLyClXR0yhv?= =?us-ascii?Q?MMhm2mzIUPnjcQ9ob/Kw8GfQ93Rm5PKQt1/QcTTkZMsWUJBh+Bj11zcbvFbI?= =?us-ascii?Q?L32MBM7pakRDyDYosvV7hpr4zeZ2+9bOZuVjA3R1+99bUyCXzGpatwk0A+EK?= =?us-ascii?Q?s2qHxLb5FHcdaJO4FX61DWWpkkzCWqh3O4D4yPYGjGg8Pm0o/VIW1D0pO/7r?= =?us-ascii?Q?wwSNeSlAa/6NUW7DLqSg0wkhIdyhMzDTyb1VeQr7d1/zXjmnhFtwJ7eiinTO?= =?us-ascii?Q?Aros5mj3rbLfydr+rM+hVFN7wgkLBL0njM1JGHNsOAEvBFw7tuakKQ1cl97q?= =?us-ascii?Q?fZyatsLrop1riGBOTLdT1nkTp/Dj+XYQ82/W2SCMpzGpnuAYkM1rK/+DUXtP?= =?us-ascii?Q?riEpHodYazWr8/2SQQ9MuGcPrAw53tMOd2O8a5bS1kz+M60fXiLw+4FO8zS2?= =?us-ascii?Q?bGAQOUjEKupYQ8kY6JraNPTcdCUl0DOs0ABhnfKHHCQgmNnYIfb0j8gKiTL0?= =?us-ascii?Q?sExO0ArvTiY4/+CvnxQhjK7E8o=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;6:juJ1JNnKtAP9EYCrH/qGVd7ANEnIZhbY7O4IRReHe3wOiydy5xdvbfHh2BeI8WVW5otNSW8sL6Ijp0YqJYw50a6YybcHpnzWw3A10QxMP/C5KuhkRv0jqy5r1A805FS3cVcQcnY3hyx0SdwVUoZOmsbKberW1fuzyC6EC81ndX7DLinpIbkzJaetU3z5Ftqy6MU3P82NKrNzrSLthBiLnoxdG9Q2pvU808M4krhzBoqLn1XwfgrFdjTft1B8TbBGDC+7R28+LmOl5fqQIgRQAR6s3PO50rQ8EVq1Gv7Kw2u+TUxq9peiX5AVQ78ydHf+mLKEnMCCPLIF/qazAq5Xwd5VmjgCzk5qjWT6i0+fIQk31URDvHbCWuBHZRLWH9c4FwqY35ef2BjeBzk1/ef8Ow==;5:XpjkXri3BCIwel9Chu2QXatomgvXZAXKl8fBzmrJpUlkgAcQT+Zuy9i1rgcLhxZsHEv6H+wIOQM/aAsEQm4S3HMECZ8qEweJA27H02XlBqoOJG+/r3hXLVE/piCzwkNxLVw16QItJ3EYtzgXWpAbAqC3qRYyGkRZOXgrk8hAPm8=;24:SV0BJhcFZofUcJpEnsw3RaLgqIzglQiCy58eUkvMz2YglnMCohSXVrBTayuAOfpG5tAV0l6jfBt/Ka2n/SX//BwryDE1wxseLREDR3/zlM4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;7:ZEl1Odxn+PLMYowEZwKkDxNg0vMQZyi7HOrPCLapcD46Q3FdJPkQSq+O+JzdwsRTN4BVNYTgWcfovgNLeTAMeKseDx46F1MDS/fcIS5/rJQYBqTlNrozLP3OhxS7SsjQDi01lGaWxvACXQh63U228v9438xLX3hNItEm4trnMKod7z7LFQ4G0Mx4e5CfDwRJvdgKGPAta3ZOS/dcDcoF0XAH2qeLXld/5QCMqEcQyE2ViWrFjjMqhKVe4BKE8F7YQ3QiB5egDcpFYQngeubUh10S8L+BsgZs+LeQbwycgoBvkIAwo0SwI7/mm7EnyiYWhhB241h/Qdzx3HeD0SXQjg==;20:FA5HQ1Mx3vrm99hbtmeHk3/dVC0fg2Dxklr7w4pq5WwHYf2K2XOMiaDvBvVsmmbku4RDHAjhAcPA7185m/RESF9DYXFGzb7Qozm9mOcWyGyiA+wfRcBEAhdPPLsNkWppQRJvgwkbUeLet4yuQkZ2GWtS+GBCzNouhQBBR8GTwt4= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2017 21:47:33.9399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1648 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-24_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 09:08:30AM -0800, Dave Hansen wrote: > On 02/22/2017 10:50 AM, Shaohua Li wrote: > > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > "Private_Dirty: %8lu kB\n" > > "Referenced: %8lu kB\n" > > "Anonymous: %8lu kB\n" > > + "LazyFree: %8lu kB\n" > > "AnonHugePages: %8lu kB\n" > > "ShmemPmdMapped: %8lu kB\n" > > "Shared_Hugetlb: %8lu kB\n" > > I've been as guily of this in the past as anyone, but are we just going > to keep adding fields to smaps forever? For the vast, vast, majority of > folks, this will simply waste the 21 bytes * nr_vmas that it costs us to > print "LazyFree: 0 kB\n" over and over. > > Should we maybe start a habit of not printing an entry when it's "0 kB"? Interesting idea! I'd like this is a separate patch if we go this way, because this is likely to be controversial. That said, sounds there is no reason we shouldn't do this. Thanks, Shaohua