From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdBXRgV (ORCPT ); Fri, 24 Feb 2017 12:36:21 -0500 Received: from mail.kernel.org ([198.145.29.136]:33838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbdBXRgN (ORCPT ); Fri, 24 Feb 2017 12:36:13 -0500 Date: Sat, 25 Feb 2017 02:29:17 +0900 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Ananth N Mavinakayanahalli , Ingo Molnar , Michael Ellerman , Arnaldo Carvalho de Melo , Steven Rostedt , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 4/5] perf: kretprobes: offset from reloc_sym if kernel supports it Message-Id: <20170225022917.cfb45d0ea41c22fcb5d61ebb@kernel.org> In-Reply-To: <20170223191608.GC4212@naverao1-tp.localdomain> References: <75bafc91e9d381636f68ab9923ce3d52f9157a09.1487770934.git.naveen.n.rao@linux.vnet.ibm.com> <20170223181022.7d4427714cabbb7ccd6d6673@kernel.org> <20170223191608.GC4212@naverao1-tp.localdomain> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Feb 2017 00:46:08 +0530 "Naveen N. Rao" wrote: > On 2017/02/23 06:10PM, Masami Hiramatsu wrote: > > On Wed, 22 Feb 2017 19:23:40 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support for accepting sym+offset with kretprobes through a > > > line in ftrace README. Parse the same to identify support and choose the > > > appropriate format for kprobe_events. > > > > > > Signed-off-by: Naveen N. Rao > > > --- > > > tools/perf/util/probe-event.c | 47 ++++++++++++++++++++++++++++++++++++------- > > > tools/perf/util/probe-event.h | 2 ++ > > > 2 files changed, 42 insertions(+), 7 deletions(-) > > > > > [snip] > > > > > Could you reuse (refactoring) probe_type_is_available() in probe-file.c to share > > opening README file? > > Done. I've sent patches to do that, please review. OK. > > > > > Others looks good to me :) > > Thanks. I hope that's an Ack for this patchset? OK, for 1/5, 2/5, 3/5, and 5/5; Acked-by: Masami Hiramatsu And could you make v4 series including all patches? (Not only updates) > > If so, and if Ingo/Michael agree, would it be ok to take the kernel bits > through the powerpc tree like we did for kprobe_exceptions_notify() > cleanup? If it is not urgent (yes, it seems) and since it changes arch independent parts, I think this series should finally go through Ingo's tree. Thank you, -- Masami Hiramatsu