From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751597AbdBYQGd (ORCPT <rfc822;w@1wt.eu>);
        Sat, 25 Feb 2017 11:06:33 -0500
Received: from imap.thunk.org ([74.207.234.97]:57074 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751231AbdBYQGb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Feb 2017 11:06:31 -0500
Date: Sat, 25 Feb 2017 10:22:21 -0500
From: "Theodore Ts'o" <tytso@mit.edu>
To: bosrsf04@gmail.com
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
        Ingo Molnar <mingo@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Andy Lutomirski <luto@kernel.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Petr Mladek <pmladek@suse.com>, Helge Deller <deller@gmx.de>,
        Rik van Riel <riel@redhat.com>, Thomas Garnier <thgarnie@google.com>,
        Parav Pandit <pandit.parav@gmail.com>,
        "seokhoon . yoon" <iamyooon@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@intel.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, josh@joshtriplett.org,
        brkkurek192@gmail.com, conorcurry@gmail.com, fanofbond138@gmail.com
Subject: Re: [PATCH 2/3] fs: Extracts pivot_root so it can be made optional
Message-ID: <20170225152221.v7yah6d25scxaijf@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>, bosrsf04@gmail.com,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
        Ingo Molnar <mingo@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Andy Lutomirski <luto@kernel.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Petr Mladek <pmladek@suse.com>, Helge Deller <deller@gmx.de>,
        Rik van Riel <riel@redhat.com>,
        Thomas Garnier <thgarnie@google.com>,
        Parav Pandit <pandit.parav@gmail.com>,
        "seokhoon . yoon" <iamyooon@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@intel.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, josh@joshtriplett.org,
        brkkurek192@gmail.com, conorcurry@gmail.com, fanofbond138@gmail.com
References: <cover.1487974516.git.bosrsf04@gmail.com>
 <d2f07062a3c946ea32b602351823f6ce6dac8533.1487974517.git.bosrsf04@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d2f07062a3c946ea32b602351823f6ce6dac8533.1487974517.git.bosrsf04@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If you're only going to be removing a single function, instead of
having to export a bunch of previously-static functions, my preference
would be to just insert a pair of #ifdef CONFIG_PIVOT_ROOT_SYSCALL / #endif
statements around the function in question.

Is it worth it to save 600-odd bytes?  Shrug; but if that's what you
are after, I'd suggest doing it the simplest and least-instrusive way
possible.

Cheers,

						- Ted