From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbdBYSRI (ORCPT ); Sat, 25 Feb 2017 13:17:08 -0500 Received: from verein.lst.de ([213.95.11.211]:33107 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdBYSRH (ORCPT ); Sat, 25 Feb 2017 13:17:07 -0500 Date: Sat, 25 Feb 2017 19:17:04 +0100 From: "hch@lst.de" To: Jens Axboe Cc: Linus Torvalds , Bart Van Assche , "hch@lst.de" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" Subject: Re: [GIT PULL] Block pull request for- 4.11-rc1 Message-ID: <20170225181704.GB27774@lst.de> References: <1D08B61A9CF0974AA09887BE32D889DA0A74F3@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <633d226d-cec3-a01f-a069-ffff307e9715@kernel.dk> <20170220073539.GA17687@lst.de> <1D08B61A9CF0974AA09887BE32D889DA0A8CBD@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <1487957968.2575.6.camel@sandisk.com> <0af4ed69-a9d0-44be-701c-ced76b84bfef@kernel.dk> <0dc039e5-58c5-d328-0b81-bf9e7d782675@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0dc039e5-58c5-d328-0b81-bf9e7d782675@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 01:22:42PM -0700, Jens Axboe wrote: > Bart, I pushed a fix here: > > http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=61febef40bfe8ab68259d8545257686e8a0d91d1 Yeah, this looks fine to me. It was broken on blk-mq before, but basically impossible to hit. I wonder if we should have a debug mode where we set requests to a known pattern after they are freed to catch these sort of bugs.