From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdB1CDe (ORCPT ); Mon, 27 Feb 2017 21:03:34 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:52388 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbdB1CD3 (ORCPT ); Mon, 27 Feb 2017 21:03:29 -0500 Date: Mon, 27 Feb 2017 20:45:20 -0500 (EST) Message-Id: <20170227.204520.476923849195276799.davem@davemloft.net> To: bhumirks@gmail.com Cc: julia.lawall@lip6.fr, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ide: palm_bk3710: add __initdata to palm_bk3710_port_info From: David Miller In-Reply-To: <1483089602-6016-1-git-send-email-bhumirks@gmail.com> References: <1483089602-6016-1-git-send-email-bhumirks@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Feb 2017 16:46:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhumika Goyal Date: Fri, 30 Dec 2016 14:50:02 +0530 > The object palm_bk3710_port_info of type ide_port_info is never > referenced anywhere after initialization by palm_bk3710_probe. It is > also passed as a parameter to ide_host_add which is called from the init > function but this call doesn't store the object reference anywhere, and > it only dereferences the values of the fields. Therefore add __initdata > to its declaration. > > Signed-off-by: Bhumika Goyal Applied, thanks.