From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdB0KyS (ORCPT ); Mon, 27 Feb 2017 05:54:18 -0500 Received: from foss.arm.com ([217.140.101.70]:52290 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbdB0KyC (ORCPT ); Mon, 27 Feb 2017 05:54:02 -0500 Date: Mon, 27 Feb 2017 10:44:45 +0000 From: Mark Rutland To: Masahiro Yamada Cc: Viresh Kumar , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, masahiroy@kernel.org, linux-arm-kernel , Linux Kernel Mailing List Subject: Re: Recommended notation for OPP to avoid DTC warnings Message-ID: <20170227104445.GE6795@leverpostej> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 26, 2017 at 02:18:03PM +0900, Masahiro Yamada wrote: > Hi. > > > Decumentation/devicetree/bindings/opp/opp.txt > takes examples like this: > > opp@1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > opp-suspend; > }; > If we follow this notation and the device-tree is built with W=1, > DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > unit name, but no reg property > > Is there a recommended notation to avoid it? > > Maybe, simply omit the "@" ? I think just s/@/-/ should be fine, e.g. call the above opp-1000000000. Thanks, Mark.